Skip to content

transactions that aren't retried don't rollback #765

@daniel-sanche

Description

@daniel-sanche

in Transaction.call, rollback is called when retries are exhausted, or when pre-commit fails, but other exceptions cause an immediate raise, without any rollback.

To fix this, the entire __call__ function should be wrapped in a try...except block, that causes a rollback before any exceptions are raised out of the transaction

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the googleapis/python-firestore API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions