Skip to content

Refactor to generalize classes #65

@rafilong

Description

@rafilong

Refactor classes with the intent of adding async support. Refactor will enable future async classes to inherit sync functions and constants with minimal duplication in implementation and testers.

This refactor can generally be described as creating a Base counterpart (eg. BaseClient for Client) that takes all of the sync requirements, while Client inherits from BaseClient and implements functions that have reason to be async in an async implementation. The intention is to allow the addition of the async feature to have minimal impact on the existing implementation. This change allows us to inherit the bare minimum functionality for async classes while keeping testing streamlined and straightforward.

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the googleapis/python-firestore API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions