Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Conversation

@m-strzelczyk
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Jun 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2021
Applying some changes after consulting with tech writer.
@m-strzelczyk m-strzelczyk changed the title Samples docstring and comments update. Samples docstring and comments update Jun 22, 2021
@m-strzelczyk m-strzelczyk changed the title Samples docstring and comments update docs: samples docstring and comments update Jun 22, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 23, 2021
@m-strzelczyk m-strzelczyk marked this pull request as ready for review June 24, 2021 11:36
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner June 24, 2021 11:36
@m-strzelczyk m-strzelczyk requested a review from dinagraves June 24, 2021 11:36
@m-strzelczyk
Copy link
Contributor Author

@dinagraves Can you please have a look? Those changes are only to the docstrings and comments.

@dinagraves dinagraves merged commit 2d53eb1 into master Jul 2, 2021
@dinagraves dinagraves deleted the samples branch July 2, 2021 18:08
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants