Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

Conversation

@m-strzelczyk
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Making sure that synthtool won't revert the gcloud_project_env setting for sample tests like it did in #67

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Jul 22, 2021
@m-strzelczyk m-strzelczyk marked this pull request as ready for review July 22, 2021 12:26
@m-strzelczyk m-strzelczyk requested a review from a team as a code owner July 22, 2021 12:26
@m-strzelczyk m-strzelczyk requested a review from leahecole July 22, 2021 12:26
@m-strzelczyk m-strzelczyk added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
@parthea parthea removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 40afb33 into master Jul 22, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the sample_noxfile_fix branch July 22, 2021 13:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants