build: add kokoro & ci configs to 1.106.1-patch branch#847
build: add kokoro & ci configs to 1.106.1-patch branch#847danielduhh merged 8 commits intogoogleapis:1.106.1-patchfrom
Conversation
|
Warning: This pull request is touching the following templated files:
|
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
fmt-maven-plugin v2.10 is compiled for java 11, v2.9 is compiled for java 8 port of fix from googleapis/java-shared-config#90
|
#862 should remove the linkage-monitor check @BenWhitehead |
…nloadPublicBlobWithoutAuthentication (googleapis#759) Port of googleapis/google-cloud-go#3806 Fixes googleapis#755
|
This is ready to go @BenWhitehead @frankyn. I've added the Kokoro integration & passed the tests. |
| :: See documentation in type-shell-output.bat | ||
|
|
||
| "C:\Program Files\Git\bin\bash.exe" github/java-storage/.kokoro/build.sh | ||
| "C:\Program Files\Git\bin\bash.exe" %~dp0build.sh |
There was a problem hiding this comment.
Is this an expected changed?
There was a problem hiding this comment.
The kokoro changes are a result of the old branch (mar 2020) being out of date with the latest config
| @@ -0,0 +1,55 @@ | |||
| # Copyright 2020 Google LLC | |||
There was a problem hiding this comment.
New files should have 2021 year.
There was a problem hiding this comment.
This is just a copy of what the Kokoro config file looks like now
| <plugins> | ||
| <plugin> | ||
| <groupId>com.coveo</groupId> | ||
| <artifactId>fmt-maven-plugin</artifactId> |
There was a problem hiding this comment.
Missed this: You don't need to include this plugin into pom.xml.
There was a problem hiding this comment.
Ben added this in 6459701 to fix a UnsupportedClassVersionError issue
frankyn
left a comment
There was a problem hiding this comment.
The changes are super subtle. Thanks for addressing my concerns, LGTM
This adds update kokoro and ci configs to the
1.106.1-patchbranch in prep for a patch release.Required for: #844