fix(bigquery): preserve job config passed to Client methods#9735
Merged
tswast merged 1 commit intogoogleapis:masterfrom Nov 12, 2019
Merged
fix(bigquery): preserve job config passed to Client methods#9735tswast merged 1 commit intogoogleapis:masterfrom
tswast merged 1 commit intogoogleapis:masterfrom
Conversation
This commit assures that Client's methods that accept job config as an argument operate on deep copies, and do not modify the original job config instances passed to them.
tswast
approved these changes
Nov 12, 2019
This was referenced Jan 29, 2020
[CHANGE ME] Re-generated container to pick up changes in the API or client library generator.
#10256
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9727.
This PR fixes the client methods possibly modifying JobConfig instances passed to them.
How to test
Run the example from the ticket description in a debugger, and verify that the
job_configinstance is indeed not modified when passing it toclient.query(). Ditto for any other public client methods that accepts job config as an argument, including the Client class initializer.PR checklist