BigQuery: Add enum with SQL type names allowed to be used in SchemaField #9040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Aug 16, 2019
Contributor
tswast
left a comment
There was a problem hiding this comment.
Thanks. Yeah, just string values for these.
tswast
requested changes
Aug 16, 2019
Contributor
tswast
left a comment
There was a problem hiding this comment.
Oops. Actually, looks like we're missing GEOGRAPHY.
Contributor
Author
|
@tswast GEOGRAPHY is not listed among the legacy types. Am I missing something? Edit: The ticket description is somewhat ambiguous - I will add the string names names of the standard SQL types, too (as the issue title suggests), since that was probably the goal. |
Contributor
|
Thanks. Yes, all standard SQL types names are aliases in legacy SQL, so I think that makes sense. Filed b/139704786 to document GEOGRAPHY as not supported in legacy SQL, but still a valid type where legacy SQL names are expected in the API. |
tswast
approved these changes
Aug 19, 2019
emar-kar
pushed a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
…eld (googleapis#9040) * Add enum with legacy SQL type names * Add standard types to enum, rename enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7632.
This PR adds an enum of legacy SQL type names that can be used with in schema fields.
@tswast This enum is a bit different from the existing
StandardSqlDataTypesenum which maps type names to their gapic integer codes. Let me know if I misunderstood the ticket.How to test
Make sure all of the legacy SQL type names are included in the enum (and nothing else).