Removing ImportError check in Speech client.#2665
Conversation
|
It's not ideal for GAE where the gRPC won't be available for some time, but we've already crossed that bridge it seems. |
|
I'm going to leave this open before merging to let @tseaver weigh in.
@jonparrott How do you mean? |
There are other locations where grpc is not import checked, right? |
Not that I know of, except a change I made earlier today in |
|
@dhermes Gotcha. In that case I'm fine with this outside of datastore, logging, pubsub, storage, and logging. |
…import Removing ImportError check in Speech client.
Removing ImportError check in Speech client.
Removing ImportError check in Speech client.
Removing ImportError check in Speech client.
I mentioned this in #2664 and this delivers on it.
We should also get rid of all the instances of this in other packages. LMK what you both think (and @jonparrott I'd be interested in what you think, i.e. importing
grpcon GAE)