datastore: refactor transaction & datastore. #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
package.json
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM with minor issues. |
rakyll
pushed a commit
that referenced
this pull request
Aug 6, 2014
datastore: refactor transaction & datastore.
Contributor
|
Merging this! Thanks!! |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
chingor13
pushed a commit
that referenced
this pull request
Aug 26, 2022
Source-Link: googleapis/synthtool@d229a12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
chingor13
pushed a commit
that referenced
this pull request
Sep 12, 2022
* feat: upgrade to GA * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .repo-metadata.json * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * v1beta2 -> v1 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Ace Nassri <anassri@google.com>
chingor13
pushed a commit
that referenced
this pull request
Sep 12, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Sep 13, 2022
Source-Link: googleapis/synthtool@d229a12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
chingor13
pushed a commit
that referenced
this pull request
Sep 14, 2022
* feat: upgrade to GA * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update .repo-metadata.json * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * v1beta2 -> v1 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Dina Graves Portman <dinagraves@google.com> Co-authored-by: Ace Nassri <anassri@google.com>
chingor13
pushed a commit
that referenced
this pull request
Sep 14, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/nodejs-artifact-registry@v1.2.3...v1.3.0) (2022-03-23) ### Features * promote v1beta2 features to v1 ([#132](googleapis/nodejs-artifact-registry#132)) ([a217d2e](googleapis/nodejs-artifact-registry@a217d2e)) * upgrade to GA ([#96](googleapis/nodejs-artifact-registry#96)) ([1e71407](googleapis/nodejs-artifact-registry@1e71407)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Sep 17, 2025
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/sindresorhus/normalize-url/releases) - [Commits](https://github.com/sindresorhus/normalize-url/commits) --- updated-dependencies: - dependency-name: normalize-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
This was referenced Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
The tests were failing because they were testing the library against Winston@3 that is not supported. Now the tests are testing against Winston@2. fixes: #94
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
The tests were failing because they were testing the library against Winston@3 that is not supported. Now the tests are testing against Winston@2. fixes: #94
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
The tests were failing because they were testing the library against Winston@3 that is not supported. Now the tests are testing against Winston@2. fixes: #94
4 tasks
This was referenced Jan 27, 2026
This was referenced Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
I rearranged a few things, hopefully for the better. I'll leave comments. :)