Skip to content

Add Google Cloud DNS #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 1 commit into from
Jul 29, 2015
Merged

Add Google Cloud DNS #706

stephenplusplus merged 1 commit into from
Jul 29, 2015

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Jul 6, 2015

Fixes #486

To Dos

  • Add support for SPF records in Support SPF records elgs/dns-zonefile#11
  • Tests
    • Unit
      • util.exec
      • dns/index
      • dns/zone
      • dns/record
      • dns/change
    • System
  • Add GCLOUD_TESTS_DNS_DOMAIN env var to travis (value: gcloud-node.com.)
  • Docs

Docs: https://stephenplusplus.github.io/gcloud-node-gh-pages-again/#/docs/master/dns

@stephenplusplus stephenplusplus added api: dns Issues related to the Cloud DNS API. don't merge labels Jul 6, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2015
stephenplusplus
stephenplusplus reviewed Jul 6, 2015
View reviewed changes
system-test/dns.js Outdated

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the spp--dns branch 11 times, most recently from e964fe8 to bc19a17 Compare July 20, 2015 15:01
@stephenplusplus stephenplusplus force-pushed the spp--dns branch 3 times, most recently from d6348d9 to c42fdfb Compare July 21, 2015 14:42
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Jul 21, 2015

Assigned to @callmehiphop for a review, please. Probably easiest to start with the docs, and make sure the API looks sane.

callmehiphop
callmehiphop reviewed Jul 21, 2015
View reviewed changes
lib/dns/index.js

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Jul 21, 2015

@jgeewax Since we're trapped on what we can do with system testing (re: the error The 'gcloud-node.com.' managed zone is not available to be created.), here are the options we have that I can think of:

  1. Look for a GCLOUD_TESTS_DNS_DOMAIN env var and use it for system testing. This is how it is in this PR currently, and how I've been testing with my stephenplusplus.com. domain (which has yet to run into the issues gcloud-node.com. has)
  2. If the env var is set, try to create a zone. If it fails with the error above, try to get a list of zones that already exist, and use one of them to complete the tests that don't involve creating/deleting zones with.
  3. If we can't get a zone, or any of the above failed, skip the DNS tests.

It's not exactly pretty to make our tests run like that, but it's possible.

callmehiphop
callmehiphop reviewed Jul 21, 2015
View reviewed changes
lib/dns/zone.js

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jgeewax
Copy link
Contributor

jgeewax commented Jul 21, 2015

I can't find anywhere in any of my projects that have a zone for gcloud-node.com ... I opened a ticket asking WTF is going on... because that's super weird. If you know a project that has the zone created... lmk... I'd really like to use gcloud-node as the demo domain...

callmehiphop
callmehiphop reviewed Jul 21, 2015
View reviewed changes
lib/dns/zone.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this pull request Jul 21, 2015
@stephenplusplus
remove unnecessary sort property
b2f2839 
re:
googleapis#706 (comment)
This was referenced Nov 9, 2022
Closed
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@alexander-fenster
fix: do not modify options object, use defaultScopes (#706)
46f8bdc 
Regenerated the library using
[gapic-generator-typescript](https://github.com/googleapis/gapic-generator-typescript)
v1.2.1.
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 3.4.0 (#782)
2594306 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.4.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v3.3.0...v3.4.0) (2021-03-15)


### ⚠ BREAKING CHANGES

* removed ImportAgentResponse which was not ready for use yet

### Features

* add additional_bindings to Dialogflow v2 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add additional_bindings to Dialogflow v2beta1 ListIntents API docs: update copyrights and session docs ([66cd3a5](https://www.github.com/googleapis/nodejs-dialogflow/commit/66cd3a5b5c605deb37efbc4f87edf17b8d4dd4c1))
* add CCAI API ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* added support for regionalization for document API ([#722](https://www.github.com/googleapis/nodejs-dialogflow/issues/722)) ([b6f5738](https://www.github.com/googleapis/nodejs-dialogflow/commit/b6f5738613fc5af49b966d4a8c4137921abed5ef))
* adds style enum ([72bb3ae](https://www.github.com/googleapis/nodejs-dialogflow/commit/72bb3aed5fbe9a605810cce69a12fd3c5e4d1fac))
* allowed custom to specify webhook headers through query parameters ([#724](https://www.github.com/googleapis/nodejs-dialogflow/issues/724)) ([a7f784a](https://www.github.com/googleapis/nodejs-dialogflow/commit/a7f784ac921a750e9df2e6edbfa3bee870187af1))


### Bug Fixes

* **browser:** check for fetch on window ([#718](https://www.github.com/googleapis/nodejs-dialogflow/issues/718)) ([fb28879](https://www.github.com/googleapis/nodejs-dialogflow/commit/fb28879443c27688d1923d6675ea97c3c5d4d0e7))
* do not modify options object, use defaultScopes ([#706](https://www.github.com/googleapis/nodejs-dialogflow/issues/706)) ([95a938d](https://www.github.com/googleapis/nodejs-dialogflow/commit/95a938dbc5f2cc49c217bb5d3cecbbffba3e6d18))
* remove MixedAudio ([a93fa71](https://www.github.com/googleapis/nodejs-dialogflow/commit/a93fa71d45cace7822d5585a8a407e3e7e563686))
* removed ImportAgentResponse which was not ready for use yet ([e0d9fa6](https://www.github.com/googleapis/nodejs-dialogflow/commit/e0d9fa69bba79540c09ec777b3eee6bf0bd5e4b6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@renovate-bot
chore(deps): update dependency webpack-cli to v5 (#706)
66a134f
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@sofisl @summer-ji-eng @gcf-owl-bot
build!: update library to use Node 12 (#706)
5e5a8ac 
* build!: Update library to use Node 12
Co-authored-by: Summer Ji <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
@sofisl @summer-ji-eng @gcf-owl-bot
build!: update library to use Node 12 (#706)
4ef5a56 
* build!: Update library to use Node 12
Co-authored-by: Summer Ji <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
GautamSharda pushed a commit that referenced this pull request Jan 21, 2026
@sofisl @summer-ji-eng @gcf-owl-bot
build!: update library to use Node 12 (#706)
9de0b9d 
* build!: Update library to use Node 12
Co-authored-by: Summer Ji <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
@sofisl sofisl mentioned this pull request Jan 27, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
8d5ff24 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
43c34ca 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
@sofisl sofisl mentioned this pull request Jan 27, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
07770fa 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
This was referenced Jan 27, 2026
Closed
Closed
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
3308f63 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
This was referenced Jan 27, 2026
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Jan 28, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
add29ae 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
@sofisl sofisl mentioned this pull request Jan 28, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 28, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
5be22a8 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
@sofisl sofisl mentioned this pull request Jan 28, 2026
Closed
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
@yoshi-automation
build: fix typo in publish (#706)
3de8535 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5b03461e-47c0-40e8-a8ad-c465ee146cc5/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@388e10f
Source-Link: googleapis/synthtool@d82decc
Source-Link: googleapis/synthtool@799d8e6
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 28, 2026
Open
sofisl pushed a commit that referenced this pull request Jan 29, 2026
@nolanmar511
Revert "fix: Update engines to prevent agent from getting used when i…
3ce212c 
…t will cause memory leak." (#706)

* Revert "fix: Update engines to prevent agent from being used with versions of Node.js where v8 profilers have memory leaks (#699)"

This reverts commit 160d1f68c657f6ce18b8cea921470d1b4482619f.

* address comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephenplusplus @jgeewax @callmehiphop @googlebot