-
Notifications
You must be signed in to change notification settings - Fork 641
support local datastore #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support local datastore #407
Conversation
5d9832d to
009d76c
Compare
lib/common/util.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Re: |
test/datastore/request.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good to me otherwise. Let me know what you think about just one string for configuration e.g. "http://localhost:8080" instead of two or three. |
SGTM. 👍 |
|
Sent in an update using |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Cool beans. Looks good. Just could benefit from a couple example as I commented. |
5a44544 to
78358d4
Compare
|
Good idea. Added those: 78358d4 |
…tore support local datastore
|
Thanks! 💃 |
* chore: clean up Node.js TOC for cloud-rad Source-Author: F. Hinkelmann <[email protected]> Source-Date: Wed Oct 21 09:26:04 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: f96d3b455fe27c3dc7bc37c3c9cd27b1c6d269c8 Source-Link: googleapis/synthtool@f96d3b4 * chore: fix Node.js TOC for cloud-rad Source-Author: F. Hinkelmann <[email protected]> Source-Date: Wed Oct 21 12:01:24 2020 -0400 Source-Repo: googleapis/synthtool Source-Sha: 901ddd44e9ef7887ee681b9183bbdea99437fdcc Source-Link: googleapis/synthtool@901ddd4
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d365a9d3-f86e-4598-8272-bbf6b821e385/targets - [ ] To automatically regenerate this PR, check this box.
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d365a9d3-f86e-4598-8272-bbf6b821e385/targets - [ ] To automatically regenerate this PR, check this box.
Fixes #389
While running the gcd server, this now works:
I'm not sure
hostandportare technically correct argument names, since for this PR, "host" needs to be in the format of protocol + host ("http://localhost"). Ideas I can think of:hostandportin favor of one argument name to include protocol + host + port (but not a path):uriresourceapiapiPrefixprotocol,host, andportInterested in your thoughts!