Skip to content

storage: download integrity check #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 1 commit into from
Dec 10, 2014
Merged

storage: download integrity check #310

stephenplusplus merged 1 commit into from
Dec 10, 2014

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Nov 24, 2014

Picking up from #299, where we're implementing integrity checks for uploads.

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch 2 times, most recently from 64aa8dc to b4f3d8d Compare November 24, 2014 17:33
@ryanseys
Copy link
Contributor

ryanseys commented Nov 24, 2014

Does this depend on #299 being merged first?

On Monday, November 24, 2014, Stephen Sawchuk [email protected]
wrote:

Picking up from #299
#299, where

we're implementing integrity checks for uploads.

You can merge this Pull Request by running

git pull https://github.com/stephenplusplus/gcloud-node spp--storage-download-integrity

Or view, comment on, or merge it at:

#310
Commit Summary

  • storage: download integrity check

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#310.

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Nov 24, 2014

No, sir.

ryanseys
ryanseys reviewed Nov 24, 2014
View reviewed changes
lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from 6021be0 to 9367598 Compare November 24, 2014 18:26
@stephenplusplus stephenplusplus mentioned this pull request Nov 24, 2014
Merged
6 tasks
stephenplusplus
stephenplusplus reviewed Nov 24, 2014
View reviewed changes
lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from 9eaef75 to 14b48b5 Compare November 25, 2014 20:01
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Dec 1, 2014

@ryanseys going to re-answer your earlier question. It probably makes sense to wait for #299 to go before merging this one, since there will be some shared functions I can make use of in this PR that are going to go with that PR.

Left a note to hold off in the description 👍

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from a1b2671 to 3df8817 Compare December 5, 2014 18:50
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Dec 5, 2014

This one should be ready for another look.

ryanseys
ryanseys reviewed Dec 8, 2014
View reviewed changes
lib/storage/file.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ryanseys
Copy link
Contributor

ryanseys commented Dec 8, 2014

I've looked at this. It looks overall good, just a few notes you may wish to address. If you make those small changes and squash, I'll be happy to merge.

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from 8426ceb to 4f03ef7 Compare December 8, 2014 20:25
stephenplusplus referenced this pull request in stephenplusplus/gcloud-node Dec 8, 2014
@stephenplusplus
storage: clarify documentation about download integrity
4f03ef7 
https://github.com/GoogleCloudPlatform/gcloud-node/pull/310\#discussion-diff-21434792
@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from 4f03ef7 to 88e9eab Compare December 8, 2014 20:25
stephenplusplus referenced this pull request in stephenplusplus/gcloud-node Dec 8, 2014
@stephenplusplus
storage: clarify documentation about download integrity
88e9eab 
https://github.com/GoogleCloudPlatform/gcloud-node/pull/310\#discussion-diff-21434792
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Dec 8, 2014

Thanks for the review! I squashed and tried to make the docs a little more clear in 88e9eab

@stephenplusplus stephenplusplus force-pushed the spp--storage-download-integrity branch from 9802af2 to c7c6e60 Compare December 10, 2014 17:43
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Dec 10, 2014

@ryanseys squashed and fixed the logic line you left a comment on. Merging!

stephenplusplus added a commit that referenced this pull request Dec 10, 2014
@stephenplusplus
Merge pull request #310 from stephenplusplus/spp--storage-download-in…
23d399c 
…tegrity

storage: download integrity check
@stephenplusplus stephenplusplus merged commit 23d399c into googleapis:master Dec 10, 2014
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@JustinBeckwith
feat: add avro support (#310)
38906dc
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@yoshi-automation @JustinBeckwith
build: update release config (#310)
4b054b3
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@yoshi-automation @JustinBeckwith
build: update release config (#310)
0cf3fe1
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@callmehiphop @JustinBeckwith
fix(typescript): make dnsName a required field (#310)
611f487
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 14, 2026
Closed
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@renovate @JustinBeckwith
chore(deps): update dependency jsdoc to v3.6.2 (#310)
4297f9c
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 14, 2026
Closed
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@ofrobots @JustinBeckwith
refactor: cleanup types for reportManualError (#310)
43f78b8
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@DominicKramer @JustinBeckwith
chore(chore): upgrade to gts 1.0.0 (#310)
0de0bbb 
* chore: upgrade to gts 1.0.0

* chore: run `gts fix`

* chore: fix `gts check` errors
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
@ofrobots @JustinBeckwith
refactor: cleanup types for reportManualError (#310)
1be418c
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
@DominicKramer @JustinBeckwith
chore(chore): upgrade to gts 1.0.0 (#310)
a19e640 
* chore: upgrade to gts 1.0.0

* chore: run `gts fix`

* chore: fix `gts check` errors
@GautamSharda GautamSharda mentioned this pull request Jan 20, 2026
Open
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026
@renovate @JustinBeckwith
chore(deps): update dependency jsdoc to v3.6.2 (#310)
64000b9
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 21, 2026
Open
GautamSharda pushed a commit that referenced this pull request Jan 21, 2026
@DominicKramer @JustinBeckwith
chore(chore): upgrade to gts 1.0.0 (#310)
62832c4 
* chore: upgrade to gts 1.0.0

* chore: run `gts fix`

* chore: fix `gts check` errors
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
@sofisl sofisl mentioned this pull request Jan 27, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511 @aalexand
fix: updated golint import path in tests (#310)
aab3526
This was referenced Jan 27, 2026
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511 @aalexand
fix: updated golint import path in tests (#310)
1a0eeba
This was referenced Jan 27, 2026
Closed
Closed
Closed
Closed
Closed
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
@evgenius @JustinBeckwith
fix(types): Make gaxOptions optional in Transaction.rollback() (#310)
e4a9f34
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 28, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenplusplus @ryanseys @silvolu