datastore: tests: refactor pb/transaction.

[stephenplusplus]

This makes it so protobuf request encoding/response decoding and transactional/non-transactional properties are all handled in one place.

[ryanseys]

Overall looks really good. Just wondering why createRequest_ takes a req object? It's confusing that a method that creates requests needs a "request". :) Can we clarify that?

[stephenplusplus]

You named it, bro :p. I was thinking that, too. How about makeReq like the
other places?

On Sunday, October 12, 2014, Ryan Seys [email protected] wrote:

Overall looks really good. Just wondering why createRequest_ takes a req
object? It's confusing that a method that creates requests needs a
"request". :) Can we clarify that?

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

[ryanseys]

I renamed it from makeReq_. Yes we can change it back if you'd like, but that still doesn't help explain why it takes a request object :P

[stephenplusplus]

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys [email protected] wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

[stephenplusplus]

And our requester is called request, which takes the request from our
makeReq request.

Whoa.

On Sunday, October 12, 2014, Stephen Sawchuk [email protected] wrote:

It's piping the request up to our "requester", adding headers along the
way. So, I guess the thought was make a request with this request object.
That was Burcu's design, just my interpretation ^

On Sunday, October 12, 2014, Ryan Seys <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

I renamed it from makeReq_. Yes we can change it back if you'd like,
but that still doesn't help explain why it takes a request object :P

—
Reply to this email directly or view it on GitHub
#255 (comment)
.

[ryanseys]

And if I recall correctly, we use the request library to send the requests ;)

[stephenplusplus]

-createRequest_
+makeReq_

[silvolu]

Maybe rename req to something like requestBody ?

[stephenplusplus]

Renamed to body

[silvolu]

@ryanseys any better?

[ryanseys]

Yes, this is better!

[ryanseys]

LGTM.