storage: fix signed url tests. fixes #238 #239

stephenplusplus · 2014-09-23T13:41:52Z

Removed the regression test
Added a test that the expiration date we passed was honored by our code. Whether that's honored upstream or not is in the hands of another library's code :)

test/storage/index.js

ryanseys · 2014-09-23T13:58:34Z

Other than nit, LGTM

silvolu · 2014-09-23T17:24:51Z

While you're at it, do you also want to add a check that expiration is not in the past, and error if that's the case?

stephenplusplus · 2014-09-23T17:25:24Z

👍 Yes!

stephenplusplus · 2014-09-23T17:34:34Z

PTAL.

silvolu · 2014-09-23T17:38:28Z

LGTM, merging.

storage: fix signed url tests. fixes #238

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

Source-Link: googleapis/synthtool@d229a12 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e

fix(deps): update dependency arrify to v2 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | arrify | dependencies | major | [`^1.0.1` -> `^2.0.0`](https://diff.intrinsic.com/arrify/1.0.1/2.0.0) | [source](https://togithub.com/sindresorhus/arrify) | --- ### Release Notes <details> <summary>sindresorhus/arrify</summary> ### [`v2.0.0`](https://togithub.com/sindresorhus/arrify/releases/v2.0.0) [Compare Source](https://togithub.com/sindresorhus/arrify/compare/v1.0.1...v2.0.0) Breaking: - Require Node.js 8 ([#6](https://togithub.com/sindresorhus/arrify/issues/6)) [`8d6734f`](https://togithub.com/sindresorhus/arrify/commit/8d6734f) Enhancements: - Add TypeScript definition ([#6](https://togithub.com/sindresorhus/arrify/issues/6)) [`8d6734f`](https://togithub.com/sindresorhus/arrify/commit/8d6734f) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/nodejs-translate). #239 automerged by dpebot

🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/nodejs-dialogflow-cx@v2.15.0...v3.0.0) (2022-06-23) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#288) ### Features * add Webhook samples ([#259](googleapis/nodejs-dialogflow-cx#259)) ([709dc6d](googleapis/nodejs-dialogflow-cx@709dc6d)) * added audio_export_settings ([#257](googleapis/nodejs-dialogflow-cx#257)) ([39f1d1c](googleapis/nodejs-dialogflow-cx@39f1d1c)) * added data format specification for export agent ([361e7d9](googleapis/nodejs-dialogflow-cx@361e7d9)) * added data format specification for export agent ([361e7d9](googleapis/nodejs-dialogflow-cx@361e7d9)) * added page in TestConfig ([7adaf67](googleapis/nodejs-dialogflow-cx@7adaf67)) * added page in TestConfig ([#239](googleapis/nodejs-dialogflow-cx#239)) ([283c389](googleapis/nodejs-dialogflow-cx@283c389)) * added support for locking an agent for changes ([361e7d9](googleapis/nodejs-dialogflow-cx@361e7d9)) * added support for locking an agent for changes ([361e7d9](googleapis/nodejs-dialogflow-cx@361e7d9)) ### Build System * update library to use Node 12 ([#288](googleapis/nodejs-dialogflow-cx#288)) ([9a72b32](googleapis/nodejs-dialogflow-cx@9a72b32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7de5fca1-c450-46ed-b4bd-ed0a7f991ee4/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 361273630 Source-Link: googleapis/googleapis@5477122

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 413691586 Source-Link: googleapis/googleapis@5915024 Source-Link: googleapis/googleapis-gen@afe7901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWZlNzkwMWU5MmMwYmFiMDg4OGNkMjk3MTlhNmI3NThkN2UwZGQzNSJ9 feat: add id field to DeployedModel feat: add service_attachment field to PrivateEndpoints feat: add endpoint_id to CreateEndpointRequest and method signature to CreateEndpoint feat: add method signature to CreateFeatureStore, CreateEntityType, CreateFeature feat: add network and enable_private_service_connect to IndexEndpoint feat: add service_attachment to IndexPrivateEndpoints feat: add stratified_split field to training_pipeline InputDataConfig

stephenplusplus added in progress and removed in progress labels Sep 23, 2014

ryanseys reviewed Sep 23, 2014
View reviewed changes

stephenplusplus force-pushed the spp--signed-url-test branch from 1a176ae to df43bdd Compare September 23, 2014 14:03

storage: fix signed url tests. fixes googleapis#238

0ff03a1

stephenplusplus force-pushed the spp--signed-url-test branch from df43bdd to 0ff03a1 Compare September 23, 2014 17:34

silvolu added a commit that referenced this pull request Sep 23, 2014

Merge pull request #239 from stephenplusplus/spp--signed-url-test

7be2cae

storage: fix signed url tests. fixes #238

silvolu merged commit 7be2cae into googleapis:master Sep 23, 2014

beriberikix removed the ready for review label Sep 23, 2014

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

refactor: use explicit mocha imports (#239)

f5a0d67

sofisl pushed a commit that referenced this pull request Oct 12, 2022

chore: release 1.1.3 (#239)

b450fb9

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

This was referenced Oct 12, 2022

migrate code from googleapis/nodejs-resource-manager #3402

Merged

migrate code from googleapis/nodejs-phishing-protection #3406

Merged

sofisl pushed a commit that referenced this pull request Oct 13, 2022

build(owlbot): configuration for real-time OwlBot updates (#239)

54a2f68

sofisl mentioned this pull request Oct 13, 2022

migrate code from googleapis/nodejs-recommender #3409

Merged

4 tasks

This was referenced Oct 13, 2022

chore: release main #3411

Closed

chore: release main #3421

Closed

chore: release main #3422

Closed

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-text-to-speech #3528

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

fix(docs): move to new client docs URL (#239)

8385f34

sofisl pushed a commit that referenced this pull request Nov 10, 2022

feat: support apiEndpoint override in client constructor (#239)

1ca13df

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-tasks #3530

Merged

4 tasks

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-recaptcha-enterprise #3645

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 17, 2022

chore: remove repo-tools from a few spots (#239)

c529d36

This was referenced Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

migrate code from googleapis/nodejs-security-center #3669

Merged

sofisl pushed a commit that referenced this pull request Nov 18, 2022

chore: remove snippet leading whitespace (#239)

2da6274

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

build: use linkinator for docs test (#239)

b2a14d1

sofisl mentioned this pull request Jan 26, 2023

migrate code from googleapis/nodejs-ai-platform #3892

Merged

4 tasks

takeratta mentioned this pull request Dec 14, 2023

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#55

Open

This was referenced Jan 2, 2024

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#58

Open

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#62

Open

takeratta mentioned this pull request Mar 16, 2024

[Snyk] Security upgrade google-gax from 0.14.5 to 0.17.0 takeratta/google-cloud-node#65

Open

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore: Update sinon to the latest version 🚀 (#239)

81b9a4d

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6991

Closed

miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026

build: check broken links in generated docs (#239)

a267009

miguelvelezsa mentioned this pull request Jan 14, 2026

migrate code from googleapis/nodejs-logging-bunyan #6995

Closed

miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026

build: check broken links in generated docs (#239)

4e7db97

miguelvelezsa mentioned this pull request Jan 21, 2026

migrate code from googleapis/nodejs-logging-bunyan #7021

Open

sofisl mentioned this pull request Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7043

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Jan 27, 2026

chore(deps): update dependency gts to ^0.6.0 (#239)

2f693f1

This was referenced Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7044

Closed

migrate code from googleapis/cloud-profiler-nodejs #7045

Closed

migrate code from googleapis/cloud-profiler-nodejs #7046

Closed

sofisl pushed a commit that referenced this pull request Jan 27, 2026

chore(deps): update dependency gts to ^0.6.0 (#239)

80d2ac1

This was referenced Jan 27, 2026

migrate code from googleapis/cloud-profiler-nodejs #7047

Closed

migrate code from googleapis/cloud-profiler-nodejs #7048

Closed

migrate code from googleapis/cloud-profiler-nodejs #7049

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: fix signed url tests. fixes #238 #239

storage: fix signed url tests. fixes #238 #239

Uh oh!

stephenplusplus commented Sep 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Sep 23, 2014

Uh oh!

silvolu commented Sep 23, 2014

Uh oh!

stephenplusplus commented Sep 23, 2014

Uh oh!

stephenplusplus commented Sep 23, 2014

Uh oh!

silvolu commented Sep 23, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

storage: fix signed url tests. fixes #238 #239

storage: fix signed url tests. fixes #238 #239

Uh oh!

Conversation

stephenplusplus commented Sep 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ryanseys commented Sep 23, 2014

Uh oh!

silvolu commented Sep 23, 2014

Uh oh!

stephenplusplus commented Sep 23, 2014

Uh oh!

stephenplusplus commented Sep 23, 2014

Uh oh!

silvolu commented Sep 23, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants