Skip to content

pubsub: refactor (fixes #98). #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stephenplusplus wants to merge 2 commits into from
Closed

pubsub: refactor (fixes #98). #107

stephenplusplus wants to merge 2 commits into from

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Aug 12, 2014

Here's the PubSub API refactor (#98)! The readme updates + tests (regression & unit) will be good places to see it in action. Let me know if you see anything you think can be improved!

Note: this could likely still use a few more tests, and definitely needs a sweep for doc block accuracy. I'll get to these soon.

rakyll
rakyll reviewed Aug 12, 2014
View reviewed changes
lib/pubsub/index.js Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@rakyll
Copy link
Contributor

rakyll commented Aug 12, 2014

Added some comments, also applicable to Topic get/create/initialize.

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 12, 2014

Will get right to it 👍

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 12, 2014

Made the updates!

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 12, 2014

Oops, not to the readme. I'll get to that next.

stephenplusplus
stephenplusplus reviewed Aug 12, 2014
View reviewed changes
lib/common/util.js

This comment was marked as spam.

Sign in to view

stephenplusplus
stephenplusplus reviewed Aug 12, 2014
View reviewed changes
lib/pubsub/subscription.js

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@rakyll
Copy link
Contributor

rakyll commented Aug 13, 2014

This PR is getting too big to review, can we first work on Subscription only?

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 13, 2014

This PR is getting too big to review, can we first work on Subscription only?

Sure, I can start over. It sounds like we're keeping consistent with the old API, as far as behavior, with some name changes: listSubscriptions -> getSubscriptions, getSubscription -> subscribe and such. Hopefully that will ease the complexity this PR brought on. Speaking of this PR, I'll close it since "fixes #98" won't be an accurate association.

@stephenplusplus stephenplusplus mentioned this pull request Aug 13, 2014
Closed
@stephenplusplus stephenplusplus mentioned this pull request Mar 18, 2015
Closed
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@JustinBeckwith
build: use linkinator for docs test (#107)
48ce788
@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@JustinBeckwith
chore: update nyc and eslint configs (#107)
9e81cf2
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@renovate @JustinBeckwith
chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…
c77c75f 
…107)
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@renovate @JustinBeckwith
chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…
373b539 
…107)
This was referenced Oct 5, 2022
Closed
Closed
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@renovate @JustinBeckwith
chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…
30b3f06 
…107)
This was referenced Oct 11, 2022
Merged
Merged
@sofisl sofisl mentioned this pull request Nov 16, 2022
Merged
4 tasks
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@JustinBeckwith
chore: do not use npm ci (#107)
2dc1c50
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#107)
d2db212
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@renovate @JustinBeckwith
chore(deps): lock file maintenance (#107)
5250c12
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/common to ^0.25.0 (#107)
cc7e623
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
@JustinBeckwith @stephenplusplus
chore: require node 8 for samples (#107)
8d948d9
This was referenced Jan 14, 2026
Closed
Closed
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@DominicKramer
chore: re-enable noImplicitAny (#107)
07d834a
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
@JustinBeckwith
refactor: drop repo-tool as an exec wrapper (#107)
7aba2ff
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
@DominicKramer
chore: re-enable noImplicitAny (#107)
a647b70
GautamSharda pushed a commit that referenced this pull request Jan 20, 2026
@JustinBeckwith
refactor: drop repo-tool as an exec wrapper (#107)
3c2795f
@GautamSharda GautamSharda mentioned this pull request Jan 20, 2026
Open
4 tasks
miguelvelezsa pushed a commit that referenced this pull request Jan 21, 2026
@JustinBeckwith @stephenplusplus
chore: require node 8 for samples (#107)
5166421
@miguelvelezsa miguelvelezsa mentioned this pull request Jan 21, 2026
Open
GautamSharda pushed a commit that referenced this pull request Jan 21, 2026
@JustinBeckwith
refactor: drop repo-tool as an exec wrapper (#107)
f8ea538
@GautamSharda GautamSharda mentioned this pull request Jan 21, 2026
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
feat: add source mapping to tests for better stack traces (#107)
c64d9b8
This was referenced Jan 27, 2026
Closed
Closed
Closed
Closed
sofisl pushed a commit that referenced this pull request Jan 27, 2026
@nolanmar511
feat: add source mapping to tests for better stack traces (#107)
27d812e
This was referenced Jan 27, 2026
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephenplusplus @rakyll