Skip to content

ci: adding gitignore check #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
suztomo merged 4 commits into from
Oct 10, 2022
Merged

ci: adding gitignore check #8560

suztomo merged 4 commits into from
Oct 10, 2022

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Oct 10, 2022 •
edited
Loading

Fixes #8547 .

@suztomo
Copy link
Member Author

suztomo commented Oct 10, 2022 •
edited
Loading

First, running the check before fixing gitignore. "Generated Files Sync / Generated files should not match gitignore" should fail. It worked:

Screen Shot 2022-10-10 at 9 19 02 AM

This is the cause of the java-gsuite-addons problem.

@suztomo suztomo changed the title ci: added gitignore check ci: adding gitignore check Oct 10, 2022
@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@suztomo suztomo merged commit a8aafa4 into googleapis:main Oct 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2022
@suztomo suztomo deleted the gitignore_check branch October 10, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison approved these changes

+1 more reviewer

@ddixit14 ddixit14 ddixit14 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Many APIs" OwlBot pull request is trying to delete java-gsuite-addons's docs package

3 participants

@suztomo @burkedavison @ddixit14