chore: exclude and remove unnecessary owlbot postprocessor templates #8492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqiu96
approved these changes
Sep 30, 2022
suztomo
reviewed
Sep 30, 2022
| done | ||
| perl_command+='\n])/s' | ||
| # execute the replacement in owlbot.py | ||
| perl -0pe "$perl_command" 'owlbot.py' > 'owlbot.py.new' && rm 'owlbot.py' && mv 'owlbot.py.new' 'owlbot.py' |
Member
There was a problem hiding this comment.
I think a better approach is to fix OwlBot Java PostProcessor to use a new template specific to monorepo.
Currently it uses the same template as split repos (both hand-written and auto-generated) https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/java_library
Member
Author
There was a problem hiding this comment.
Where's the new template? Note that we can't simply replace all of the owlbot.py configs in every module because many of them have various customizations. Example: https://github.com/googleapis/google-cloud-java/blob/main/java-vision/owlbot.py
Member
There was a problem hiding this comment.
suztomo
approved these changes
Sep 30, 2022
Comment on lines
+24
to
+35
| java.common_templates(excludes=[ | ||
| ".github/*", | ||
| ".kokoro/*", | ||
| ".samples/*", | ||
| "CODE_OF_CONDUCT.md", | ||
| "CONTRIBUTING.md", | ||
| "LICENSE", | ||
| "SECURITY.md", | ||
| "java.header", | ||
| "license-checks.xml", | ||
| "renovate.json" | ||
| ]) |
suztomo
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Oct 4, 2022
…oogleapis#8492) * chore: exclude and remove unnecessary templates * chore: apply update_owlbot_postprocessor_config.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to remove and exclude the OwlBot Post-processor templates that are no longer needed, and also applies the script to the repo in a separate commit.