Merged
Conversation
d851d5c to
48e98da
Compare
Contributor
|
The unit tests are failing: |
Contributor
|
@shollyman, we no longer retry on |
Contributor
|
Put together #5219 to address tests expecting retries for DEADLINE_EXCEEDED. Once that's in this can land. |
Contributor
|
@shollyman Thanks! I'm rerunning the tests now. |
Codecov Report
@@ Coverage Diff @@
## master #5198 +/- ##
=========================================
Coverage ? 50.45%
Complexity ? 23855
=========================================
Files ? 2257
Lines ? 227301
Branches ? 24976
=========================================
Hits ? 114694
Misses ? 103989
Partials ? 8618
Continue to review full report at Codecov.
|
shollyman
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: