ci: no retry for flakes in coverage builds

[coryan]

This change is 

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b312cb4) 93.60% compared to head (de9bb5e) 93.60%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12752      +/-   ##
==========================================
- Coverage   93.60%   93.60%   -0.01%     
==========================================
  Files        2075     2075              
  Lines      182377   182377              
==========================================
- Hits       170715   170710       -5     
- Misses      11662    11667       +5     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbolduc]

Consider leaving integration.sh alone and doing something like:

# With code coverage the `--flaky_test_attempts`
# works in unexpected ways. A flake produces an empty `coverage.dat` file, which
# breaks the build when trying to consolidate all the `coverage.dat` files.
#
# This combination of a "successful" test (because the flake is retried) and a
# failure later in the consolidation of coverage results easily leads the
# developer astray.
coverage_args=("${args[@]" "${integration_args[@]/--flaky_test_attempts=3/}")
integration::bazel_with_emulators coverage "${coverage_args[@]}" 

[devbww]

If you don't like the explicit 3, try ...

# blah blah blah
let i=0
for arg in "${integration_args[@]}"
do
  case "${arg}" in
  --flaky_test_attempts=*)
    unset integration_args[$i]
    ;;
  esac
  let ++i
done

This also has the advantage of removing the array element, rather than replacing it with an empty string.