Don’t break right after an HTML code tag that’s followed by a literal#638
Open
now wants to merge 1 commit intogoogle:masterfrom
Open
Don’t break right after an HTML code tag that’s followed by a literal#638now wants to merge 1 commit intogoogle:masterfrom
now wants to merge 1 commit intogoogle:masterfrom
Conversation
If a CODE_OPEN_TAG token is followed by a LITERAL token, break before writing the CODE_OPEN_TAG token if writing it will result in us eating up the remainder of the current line. Partially fixes google#84.
Contributor
Author
|
Could someone please have a look at this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
CODE_OPEN_TAGtoken is followed by aLITERALtoken, break before writing theCODE_OPEN_TAGtoken if writing it will result in us eating up the remainder of the current line.Partially fixes #84.
I’m not super happy about the
breakBeforeIfAtEndOfLinename, but that’s the best I could come up with right now. I also wish there was a cleaner way of peeking at the next token.