feat: Immutable releases support#3725
feat: Immutable releases support#3725gmlewis merged 1 commit intogoogle:masterfrom scop:feat/immutable-release
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 187 187
Lines 16686 16686
=======================================
Hits 15204 15204
Misses 1295 1295
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you, @scop! |
|
Oops, done. |
| TarballURL: Ptr("http://tarballurl/"), | ||
| Author: &User{Name: Ptr("octocat")}, | ||
| NodeID: Ptr("nodeid"), | ||
| Immutable: Ptr(false), |
There was a problem hiding this comment.
We can't set Immutable in CreateRelease, see https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release--parameters
There was a problem hiding this comment.
We can't set
ImmutableinCreateRelease, see https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release--parameters
If I understand correctly, @alexandear, this is a case where the documentation does not properly reflect the actual behavior of the system. In #3720 there is a demonstration using curl of receiving the immutable field, so it does indeed appear to exist.
There was a problem hiding this comment.
This added line is in a section commented as "Fields to be removed". It contains a bunch of other fields that I suppose one cannot set when creating a release, such as the release id, created at, published at, etc. IIUC the purpose of having these set here is to verify that we will not be sending them in create requests even if they're set.
|
Thank you, @alexandear! |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @scop and @alexandear!
LGTM.
Merging.
https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/immutable-releases
Closes #3720
Caveat: untested beyond test suite.