feat!: Add repository query option to ListCustomPropertyValues#3598
feat!: Add repository query option to ListCustomPropertyValues#3598gmlewis merged 3 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3598 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 184 184
Lines 16143 16143
=======================================
Hits 14742 14742
Misses 1227 1227
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @kazuki-hanai!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell or @alexandear - might one of you have time for a code review? Thank you!
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
…ions for consistent naming
|
@alexandear Thank you for your review! |
|
Thank you, @alexandear and @stevehipwell! |
BREAKING CHANGE:
ListCustomPropertyValuesnow takesListCustomPropertyValuesOptionsinstead ofListOptions.Fixes: #3596
What
SSIA
Why
I want to use
repository_queryoption forOrganizationService. ListCustomPropertyValues.related issue: #3596