Merged
Conversation
Letiste
commented
Nov 23, 2023
| } | ||
| case r.StatusCode == http.StatusForbidden && | ||
| (strings.HasSuffix(errorResponse.DocumentationURL, "#abuse-rate-limits") || | ||
| strings.HasSuffix(errorResponse.DocumentationURL, "#secondary-rate-limits")): |
Contributor
Author
There was a problem hiding this comment.
Would it be good to also check for secondary rate limit in the error message to be more resilient to future documentation updates?
Contributor
There was a problem hiding this comment.
IMO, either or should be fine.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3001 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 150 150
Lines 12952 12952
=======================================
Hits 12685 12685
Misses 190 190
Partials 77 77 ☔ View full report in Codecov by Sentry. |
gmlewis
requested changes
Nov 24, 2023
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Collaborator
|
Thank you, @liaodaniel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub updated its documentation for rate limits and is now sending the following message when a secondary rate limit is triggered:
{ "message": "You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID XXXX.", "documentation_url": "https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits" }This PR updates the check on the
documentation_urlto detect a secondary rate limit