Move RateLimits method to a service#2969
Merged
gmlewis merged 2 commits intogoogle:masterfrom Oct 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 98.13% 98.11% -0.02%
==========================================
Files 148 149 +1
Lines 12787 12790 +3
==========================================
+ Hits 12548 12549 +1
- Misses 164 166 +2
Partials 75 75
|
WillAbides
reviewed
Oct 20, 2023
Contributor
There was a problem hiding this comment.
This LGTM except for the lint failure. You can fix that by calling your new method instead of client.RateLimits
edit: looks like @gmlewis beat me to it :)
gmlewis
approved these changes
Oct 20, 2023
Collaborator
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @nhAnik and @WillAbides !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2968