Drop --end-of-options from git reset command#134
Merged
Conversation
The `git reset` command does not universally support the `--end-of-options` flag across all Git versions, causing "fatal: option '--end-of-options' must come before non-option arguments" errors (e.g. on Git 2.39.5). Since the revision argument is programmatically constructed (not arbitrary user input), removing `--end-of-options` is safe and resolves the compatibility issue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover both soft and hard reset modes to verify correct command construction without --end-of-options. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
unknwon
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git resetcommand does not support--end-of-options, which causes a fatal error when used with revision arguments likeorigin/master.--end-of-optionsfrom theResetfunction and adds a test for the package-levelResetfunction.Fixes gogs/gogs#8183