Skip to content

Conversation

@gqcn
Copy link
Member

@gqcn gqcn commented Dec 1, 2024

No description provided.

@houseme
Copy link
Member

houseme commented Dec 1, 2024

https://github.com/gogf/gf/security/code-scanning 但是这些问题还是会存在

@wln32
Copy link
Member

wln32 commented Dec 1, 2024

新增的带error返回值的api可以开放给用户使用,另http参数校验那些是不是也得改成带错误处理的api,不然参数解析错误,不返回错误,而是返回默认值似乎不太好

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


The newly added api with error return value can be opened to users. In addition, the http parameter verification must also be changed to an api with error handling. Otherwise, the parameter parsing error will not return an error, but return the default value. It seems inappropriate. good

@gqcn
Copy link
Member Author

gqcn commented Dec 2, 2024

新增的带error返回值的api可以开放给用户使用,另http参数校验那些是不是也得改成带错误处理的api,不然参数解析错误,不返回错误,而是返回默认值似乎不太好

我有此考虑,暂时不在这个pr上处理,我加了个issue记录: #4001

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


The newly added api with error return value can be opened to users. In addition, the http parameter verification must also be changed to an api with error handling. Otherwise, the parameter parsing error will not return an error, but return the default value. It seems inappropriate. Very good

I have this consideration and will not deal with this pr for the time being. I have added an issue record: #4001

@gqcn gqcn added the ready to merge Used in PR, which means this PR is reviewed. label Dec 17, 2024
@gqcn gqcn changed the base branch from master to feat/v2.9.0 December 18, 2024 02:40
@gqcn gqcn merged commit a5c8b96 into feat/v2.9.0 Dec 18, 2024
20 checks passed
@gqcn gqcn deleted the feat/gconv-basic-types branch December 18, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Used in PR, which means this PR is reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants