Skip to content

fix(database/gdb): confusing error message in Insert/Update operations when table not exist or the table contains no fields #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gqcn merged 5 commits into from
May 22, 2024
+62 −0
Merged

fix(database/gdb): confusing error message in Insert/Update operations when table not exist or the table contains no fields #3553

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48be492
If the number of fields is 0 during query/update, it will be returned…
wln32 Apr 30, 2024
9d418cd
up
wln32 Apr 30, 2024
d4e6a00
up
wln32 May 8, 2024
01691cc
up
wln32 May 16, 2024
8340a95
Merge branch 'master' into Improve/gdb-get-tabfields
wln32 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions database/gdb/gdb_core_structure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,13 @@ func (c *Core) mappingAndFilterData(ctx context.Context, schema, table string, d
if err != nil {
return nil, err
}
if len(fieldsMap) == 0 {
toLowerTableName := strings.ToLower(table)
if toLowerTableName == table {
return nil, gerror.Newf("The table %s may not exist, or the field is 0", table)
}
return nil, gerror.Newf("The table %s may not exist, or the field is 0, you can try %s", table, toLowerTableName)
}
fieldsKeyMap := make(map[string]interface{}, len(fieldsMap))
for k := range fieldsMap {
fieldsKeyMap[k] = nil
Expand Down