Skip to content

Conversation

@qinyuguang
Copy link
Contributor

No description provided.

@gqcn gqcn added the awesome It's awesome! We keep watching. label Oct 25, 2022
@qinyuguang qinyuguang force-pushed the feature/contrib-nacos branch from 92aba07 to 7902bbd Compare October 25, 2022 15:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 76.55% // Head: 76.52% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7902bbd) compared to base (038548c).
Patch coverage: 51.80% of modified lines in pull request are covered.

❗ Current head 7902bbd differs from pull request most recent head 9b4d3ef. Consider uploading reports for the commit 9b4d3ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   76.55%   76.52%   -0.04%     
==========================================
  Files         581      582       +1     
  Lines       48315    48383      +68     
==========================================
+ Hits        36987    37024      +37     
- Misses       9306     9330      +24     
- Partials     2022     2029       +7     
Flag Coverage Δ
go-1.15-386 76.52% <51.80%> (-0.03%) ⬇️
go-1.15-amd64 76.53% <51.80%> (-0.06%) ⬇️
go-1.16-386 76.51% <51.80%> (-0.05%) ⬇️
go-1.16-amd64 76.52% <51.80%> (-0.06%) ⬇️
go-1.17-386 76.55% <51.80%> (-0.03%) ⬇️
go-1.17-amd64 76.54% <51.80%> (-0.01%) ⬇️
go-1.18-386 76.43% <51.80%> (-0.06%) ⬇️
go-1.18-amd64 76.48% <51.80%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
net/ghttp/ghttp_server_service_handler.go 59.70% <0.00%> (ø)
os/gcmd/gcmd_command_object.go 52.41% <0.00%> (ø)
contrib/config/nacos/nacos.go 50.76% <50.76%> (ø)
net/ghttp/ghttp_middleware_handler_response.go 89.47% <71.42%> (+0.90%) ⬆️
os/gfsnotify/gfsnotify_watcher_loop.go 83.19% <0.00%> (ø)
os/gfpool/gfpool_file.go 68.57% <0.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gqcn gqcn merged commit 8e0e878 into gogf:master Oct 26, 2022
@qinyuguang qinyuguang deleted the feature/contrib-nacos branch November 3, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awesome It's awesome! We keep watching.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants