Preserve label_command activation guards when frontmatter defines a custom if: - #48105
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
if:
There was a problem hiding this comment.
Pull request overview
Fixes label_command compilation so custom conditions refine rather than replace label guards.
Changes:
- AND-combines label and custom conditions.
- Adds regression coverage.
- Registers the release-workflow guidance file.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/tools.go |
Combines label guards with existing conditions. |
pkg/workflow/label_command_test.go |
Tests compiled activation conditions. |
.github/skills/agentic-workflows/SKILL.md |
Adds release-workflow guidance. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
| } | ||
| data.If = RenderCondition(labelConditionTree) | ||
| } | ||
| data.If = RenderCondition(BuildConditionTree(data.If, labelConditionTree.Render())) |
🤖 PR Triage — §30192186368
Why: Fixes #47594 — Next: Full CI confirmation, then fast-track merge.
|
|
@copilot please run the Unresolved review feedback:
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed the unresolved thread in commit Changes made:
Checks rerun locally: targeted workflow tests pass; |
|
@copilot please run the Unresolved review feedback:
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Confirmed on latest HEAD (
Checks rerun locally on this branch:
I also reviewed prior PR CI logs via GitHub MCP. The historical failure was the known fallback AW file drift test; current PR-head CI runs are stale/action_required after agent push and require a maintainer-triggered rerun. |
|
🎉 This pull request is included in a new release. Release: |
label_commandworkflows were dropping their compiler-derived label match guard whenever the workflow also defined a top-level frontmatterif:. That caused activation to widen from “matching label only” to “any label event that satisfies the custom condition”.Compiler behavior
label_commandcompilation to always AND-combine the derived label-trigger condition with any existing workflowif:.Regression coverage
label_commandworkflow with a custom top-levelif:.Result
label_commandactivation instead of replacing it.Example of the compiled behavior after this change:
if:replaces the label_command-derived condition instead of combining with it #47594