Skip to content

[jsweep] Clean convert_gateway_config_claude.cjs - #47706

Merged
pelikhan merged 1 commit into
mainfrom
signed/jsweep/convert-gateway-config-claude-5c40999f84375e81
Jul 24, 2026
Merged

[jsweep] Clean convert_gateway_config_claude.cjs#47706
pelikhan merged 1 commit into
mainfrom
signed/jsweep/convert-gateway-config-claude-5c40999f84375e81

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Cleaned convert_gateway_config_claude.cjs by removing an extraneous rewriteUrl re-export.

Context type

Node.js (runs outside github-script, uses shim.cjs to inject core global)

Changes made

  • Removed rewriteUrl from import destructuring — the function was imported from convert_gateway_config_shared.cjs but never used within this module; it was only re-exported, leaking an unintended API surface.
  • Removed rewriteUrl from module.exports — aligns with the pattern in convert_gateway_config_codex.cjs, which does not re-export shared utilities.

No external consumer imports rewriteUrl from this module; the only callers use it directly from convert_gateway_config_shared.cjs.

Test coverage

The function transformClaudeEntry is already tested in convert_gateway_config_adapters.test.cjs (8 tests covering the shared pipeline and all four adapter transforms including Claude). All tests pass.

Validation checks

  • ✅ Formatting: npm run format:cjs
  • ✅ Linting: npm run lint:cjs
  • ✅ Type checking: npm run typecheck
  • ✅ Tests: npm run test:js ✓ (8/8 adapter tests pass)

Pre-existing test failures in send_otlp_span.test.cjs and setup_threat_detection.test.cjs are unrelated to this change.

Generated by 🧹 jsweep - JavaScript Unbloater · ⌖ 10.1 AIC ·

  • expires on Jul 25, 2026, 8:58 PM UTC-08:00

…e.cjs

The rewriteUrl function was imported from convert_gateway_config_shared.cjs
but not used within the module—it was only re-exported, leaking an
unintended API surface. Remove it from both the import destructuring and
module.exports to align with the pattern used in convert_gateway_config_codex.cjs
and reduce coupling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review July 24, 2026 05:02
Copilot AI review requested due to automatic review settings July 24, 2026 05:02
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

PR Code Quality Reviewer completed the code quality review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unintended, unused rewriteUrl re-export from the Claude gateway adapter.

Changes:

  • Removes rewriteUrl from shared imports.
  • Removes rewriteUrl from the module’s exports.
Show a summary per file
File Description
actions/setup/js/convert_gateway_config_claude.cjs Narrows the adapter’s API to Claude-specific functionality.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #47706 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is clean and correct — removes an unused rewriteUrl re-export from both the destructured import and module.exports, aligning with the pattern in convert_gateway_config_codex.cjs. No callers are broken. LGTM.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 8.34 AIC · ⌖ 7.27 AIC · ⊞ 5K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review

Applied /codebase-design: clean removal of unintended API surface leak. All tests green.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 12 AIC · ⌖ 4.44 AIC · ⊞ 6.7K
Comment /matt to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean removal of an unused re-export. The change is correct: rewriteUrl was imported but never called in this module, so dropping it from both the import destructuring and module.exports reduces API surface without affecting any consumer. The PR description confirms no external caller imports it from this module, and all 8 adapter tests pass. No issues found.

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 · 8.4 AIC · ⌖ 4.47 AIC · ⊞ 5.7K
Comment /review to run again

@github-actions github-actions Bot mentioned this pull request Jul 24, 2026
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@copilot run pr-finisher skill

PR finisher complete. Summary:

  • ✅ Reviews — All automated reviewers (Copilot, Impeccable Skills, Matt Pocock, PR Code Quality) returned LGTM / no issues. No unresolved threads.
  • ✅ Checks (local) — make agent-report-progress passed: fmt, lint, recompile, and unit tests all green.
  • ❓ Checks (CI) — Stale after agent push; needs human re-trigger. Prior runs: CJS workflow ran twice — the first run (30068188445) succeeded; the second (30068369304) was cancelled (no failures, superseded). mergeStateStatus: unstable reflects the in-progress copilot check (this session) which will complete momentarily.
  • ✅ Mergeable — PR is open, not draft, no conflicts, base branch up to date.

Actions taken: No file changes needed. Existing commit is correct; all local validations confirmed clean.

Hand-off: CI re-trigger is not needed (prior CJS run passed). PR is ready for human merge.

@github-actions

Copy link
Copy Markdown
Contributor Author

Great job! 🧹 This automated cleanup PR is well-executed:

  • Focused change — removes only the unused rewriteUrl re-export, aligning with the pattern in convert_gateway_config_codex.cjs
  • Well-documented — clear explanation of what was removed and why
  • Validated — all format, lint, type, and test checks pass; existing tests in convert_gateway_config_adapters.test.cjs cover the affected function
  • Minimal diff — 4 lines changed, keeping the scope tight

This is ready for review.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • patchdiff.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "patchdiff.githubusercontent.com"

See Network Configuration for more information.

Generated by ✅ Contribution Check · sonnet46 · 58.2 AIC · ⌖ 10.4 AIC · ⊞ 6.2K ·

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, update this branch if possible, confirm all review feedback is addressed, and rerun checks as needed.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10.1 AIC · ⌖ 7.6 AIC · ⊞ 7K ·
Comment /souschef to run again

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, update this branch if needed, confirm that all review feedback remains addressed, and rerun checks as needed before handoff.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 22 AIC · ⌖ 9.21 AIC · ⊞ 7K ·
Comment /souschef to run again

@pelikhan
pelikhan merged commit 18edc4c into main Jul 24, 2026
55 of 63 checks passed
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.83.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants