Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go by Copilot · Pull Request #46972 · github/gh-aw

Copilot · 2026-07-21T04:46:46Z

DomainDiffEntry, MCPToolDiffEntry, and ToolCallDiffEntry each duplicated the same three anomaly-flagging fields inline. This extracts them into a shared DiffEntryBase embed.

Changes

New DiffEntryBase struct — holds the common fields:

type DiffEntryBase struct {
    Status      string `json:"status"`
    IsAnomaly   bool   `json:"is_anomaly,omitempty"`
    AnomalyNote string `json:"anomaly_note,omitempty"`
}

Embed in all three entry types — DomainDiffEntry, MCPToolDiffEntry, and ToolCallDiffEntry each replace their inline copies with DiffEntryBase
Struct literal updates — all 8 construction sites updated to DiffEntryBase: DiffEntryBase{Status: "..."} syntax

Go struct embedding promotes fields inline in JSON output, so wire format is unchanged.

Fixes [Code Quality] Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go #46945

…it_diff.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-21T05:06:18Z

✅ PR Code Quality Reviewer completed the code quality review.

github-actions · 2026-07-21T05:06:20Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-21T05:06:20Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

github-actions · 2026-07-21T05:06:31Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #46972 does not have the 'implementation' label and has only 49 new lines of code in business logic directories (threshold: 100).

Copilot

Pull request overview

Extracts shared diff-entry fields to reduce duplication in audit output models.

Changes:

Adds DiffEntryBase.
Embeds it across three diff entry types.
Updates all construction sites.

Show a summary per file

File	Description
`pkg/cli/audit_diff.go`	Consolidates shared status and anomaly fields.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1
Review effort level: Medium

+	Domain string `json:"domain"`
+	DiffEntryBase


github-actions

Clean, correct refactor. Go struct embedding promotes Status, IsAnomaly, and AnomalyNote inline in JSON output, so wire format is unchanged. All 8 construction sites updated consistently. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · 16.8 AIC · ⌖ 4.32 AIC · ⊞ 5K

github-actions

Skills-Based Review 🧠

Applied /codebase-design — two observations, neither blocking.

📋 Key Themes & Highlights

Key Themes

Lost status-value documentation: the per-type Status field inline comments (e.g. // "new", "removed", "status_changed", "volume_changed") were dropped; DiffEntryBase has no equivalent — discoverability for new contributors suffers.
JSON field order changed: the PR claims the wire format is unchanged, but is_anomaly / anomaly_note now serialize between status and the type-specific fields rather than at the end. JSON key order does not affect encoding/json unmarshal, but it can break raw-string snapshot comparisons.

Positive Highlights

✅ Clean, focused extraction — exactly the three fields that are duplicated, nothing more.
✅ All 8 construction sites updated consistently.
✅ Go embedding correctly promotes fields into the JSON flat structure as documented.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 26.8 AIC · ⌖ 4.61 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions · 2026-07-21T05:11:25Z


+// DiffEntryBase holds common anomaly-flagging fields shared by all diff entry types.
+type DiffEntryBase struct {
+	Status      string `json:"status"`


[/codebase-design] The valid status values per entry type were documented as inline comments on the old Status fields (e.g. // "new", "removed", "status_changed", "volume_changed" on DomainDiffEntry) but were dropped during extraction — DiffEntryBase now carries no hint of what values are valid.

💡 Suggestion

Either add a comment to DiffEntryBase pointing readers to the per-type enum, or restore the per-type annotations on the embedding structs' doc comments:

// DiffEntryBase holds common anomaly-flagging fields shared by all diff entry types. // Status values are entry-type specific; see DomainDiffEntry, MCPToolDiffEntry, ToolCallDiffEntry. type DiffEntryBase struct {

This keeps discoverability intact without duplicating the value lists.

@copilot please address this.

github-actions · 2026-07-21T05:11:25Z

-	Domain       string `json:"domain"`
-	Status       string `json:"status"`                  // "new", "removed", "status_changed", "volume_changed"
+	Domain string `json:"domain"`
+	DiffEntryBase


[/codebase-design] The PR says "wire format is unchanged" but the JSON field order has shifted: is_anomaly / anomaly_note now appear between status and the type-specific fields instead of at the end. Consumers relying on key ordering (snapshot tests, jq positional scripts) may see unexpected diffs.

💡 Suggestion

Clarify in the PR body that field order changed, and verify no existing snapshot tests compare raw JSON strings. If strict trailing order is needed, move the embed to the end of each struct.

@copilot please address this.

github-actions

Clean, mechanical refactor — no correctness issues.

### Review summary

The extraction of DiffEntryBase is correct:

Go struct embedding promotes Status, IsAnomaly, and AnomalyNote inline in JSON output, so the wire format is unchanged.
All 8 construction sites are updated consistently.
No logic paths were altered.

One non-blocking doc comment issue flagged inline.

🔎 Code quality review by PR Code Quality Reviewer · 27.4 AIC · ⌖ 4.43 AIC · ⊞ 5.6K
_{Comment /review to run again}

Comments that could not be inline-anchored

pkg/cli/audit_diff.go:10

Misleading doc comment: DiffEntryBase is described as holding "anomaly-flagging fields" but Status is a general entry discriminator ("new", "removed", "changed") unrelated to anomaly detection.

<details>
<summary>💡 Suggested fix</summary>

// DiffEntryBase holds common fields shared by all diff entry types.
type DiffEntryBase struct {

Status is the primary discriminator; the anomaly fields (IsAnomaly, AnomalyNote) are secondary. The current comment misrepresents…

github-actions · 2026-07-21T08:27:41Z

🎉 This pull request is included in a new release.

Release: v0.82.15

Initial plan

124ba25

Copilot AI assigned Copilot and pelikhan Jul 21, 2026

Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request

[Code Quality] Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go #46945

Closed

Copilot started work on behalf of pelikhan July 21, 2026 04:47 View session

Extract DiffEntryBase embed to reduce anomaly-field repetition in aud…

cd59f2d

…it_diff.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Extract DiffEntryBase embed to reduce anomaly-field repetition~~ Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go Jul 21, 2026

Copilot finished work on behalf of pelikhan July 21, 2026 05:03

Copilot AI requested a review from pelikhan July 21, 2026 05:03

pelikhan marked this pull request as ready for review July 21, 2026 05:05

Copilot AI review requested due to automatic review settings July 21, 2026 05:05

Copilot started reviewing on behalf of pelikhan July 21, 2026 05:05 View session

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Comment thread pkg/cli/audit_diff.go

Comment on lines +32 to +33

Domain string `json:"domain"`

DiffEntryBase

github-actions Bot mentioned this pull request Jul 21, 2026

[aw] No-Op Runs #43499

Open

github-actions Bot approved these changes Jul 21, 2026

View reviewed changes

github-actions Bot reviewed Jul 21, 2026

View reviewed changes

github-actions Bot approved these changes Jul 21, 2026

View reviewed changes

pelikhan merged commit 4a5e7df into main Jul 21, 2026
70 of 81 checks passed

pelikhan deleted the copilot/extract-diffentrybase-embed branch July 21, 2026 05:15

This was referenced Jul 21, 2026

Smoke Test: Claude - 29804334966 #46983

Closed

Smoke Test: MAI-Code-1-Flash - 29812424728 #47025

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go#46972

Extract DiffEntryBase embed to reduce anomaly-field repetition in audit_diff.go#46972
pelikhan merged 2 commits into
mainfrom
copilot/extract-diffentrybase-embed

Copilot AI commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Jul 21, 2026

Uh oh!

github-actions Bot Jul 21, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Comments that could not be inline-anchored

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading