Propagate cancellation context through workflow job detail/status GitHub API calls#46963
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix fetchJobDetailsWithCounts to use context for cancellation
Propagate cancellation context through workflow job detail/status GitHub API calls
Jul 21, 2026
pelikhan
marked this pull request as ready for review
July 21, 2026 04:42
Collaborator
|
@copilot resolve the merge conflicts on this branch. |
Contributor
There was a problem hiding this comment.
Pull request overview
Propagates cancellation contexts through workflow job-detail and status API calls.
Changes:
- Threads context through audit and log-analysis paths.
- Updates wrappers and tests for context-aware signatures.
- Regenerates an unrelated smoke workflow lock file.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/logs_run_processor.go |
Propagates context during run analysis. |
pkg/cli/logs_orchestrator_filters.go |
Updates job-status call, but uses a detached context. |
pkg/cli/logs_orchestrator_filters_test.go |
Updates status-fetch test stubs. |
pkg/cli/logs_github_api.go |
Uses the context-aware GitHub CLI runner. |
pkg/cli/logs_github_api_test.go |
Updates job-detail tests. |
pkg/cli/audit.go |
Propagates audit context to job-detail analysis. |
.github/workflows/smoke-call-workflow.lock.yml |
Expands unrelated workflow permissions and secret forwarding. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Medium
|
|
||
| // Add failed jobs to error count. | ||
| if failedJobCount, err := fetchJobStatusesForProcessedRun(run.DatabaseID, verbose); err == nil { | ||
| if failedJobCount, err := fetchJobStatusesForProcessedRun(context.Background(), run.DatabaseID, verbose); err == nil { |
Comment on lines
+1114
to
+1117
| actions: read | ||
| contents: read | ||
| pull-requests: read | ||
| issues: write | ||
| pull-requests: write |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…tx parameter Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Merge conflicts resolved in |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchJobDetailsWithCountspreviously usedRunGHCombined, which binds tocontext.Background()and could not be cancelled on interrupt/deadline. This change threads caller context into job-detail/status fetch paths so long-running GitHub API calls can terminate promptly when the parent operation is cancelled.Problem scope
Core API change
fetchJobDetailsWithCountsnow acceptsctx context.Contextand usesworkflow.RunGHCombinedContext(ctx, ...).Context plumbing in audit path
ctxthrough:collectAuditAnalysisResultslaunchCoreAuditAnalyseslaunchJobDetailsAnalysislaunchJobDetailsAnalysisnow callsfetchJobDetailsWithCounts(ctx, ...).Wrapper and downstream propagation
fetchJobDetails(ctx, runID, verbose)fetchJobStatuses(ctx, runID, verbose)ctxthrough logs run processing where these wrappers are used (analyzeRunArtifacts/finalizeAndSaveRunSummary).Compatibility updates