Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out by Copilot · Pull Request #46014 · github/gh-aw

Copilot · 2026-07-16T14:30:29Z

This extends issue-intent behavior to close_issue, assign_to_user, and assign_to_agent, aligning them with existing issue-intent-aware mutation tools. By default, generated schemas now require rationale and confidence; each tool can independently opt out via its own issue-intent: false setting.

Schema + tool-definition coverage
- Added rationale, confidence, and suggest fields to static tool definitions for:
  - close_issue
  - assign_to_user
  - assign_to_agent
- Updated validation config for the same tools to normalize and strip invalid optional intent metadata without rejecting legacy calls.
Per-tool configuration model (safe-outputs.<tool>.issue-intent)
- Added issue-intent to per-safe-output base config (child of each safe output entry, not a global safe-outputs toggle).
- Default behavior is enabled when unset.
- Explicit issue-intent: false disables intent requirements and guidance for that tool only.
Dynamic MCP schema/description generation
- tools_meta.required_field_additions now adds ["rationale", "confidence"] for enabled tools.
- Dynamic tool description enhancer now appends/removes intent guidance based on each tool’s own issue_intent mode.
- Included close_issue, assign_to_user, and assign_to_agent in dynamic intent guidance set.
Runtime handler behavior
- Propagated issue_intent into handler configs for close/assign paths.
- Handlers now pass normalized intent metadata + feature header only when enabled and metadata is present.
- Disabled mode uses legacy behavior (no intent metadata/header), preserving GHES compatibility and runtime leniency.
Type and test updates
- Extended safe-output TS item typings so close/assign payloads can carry issue-intent metadata.
- Added/updated focused tests for:
  - required field additions default vs opt-out
  - dynamic description suffix on/off per tool
  - runtime metadata/header emission in enabled mode
  - disabled mode legacy behavior

safe-outputs:
  close-issue:
    issue-intent: false
  assign-to-user:
    issue-intent: false
  assign-to-agent:
    issue-intent: false

Generated by 👨‍🍳 PR Sous Chef · 15.2 AIC · ⌖ 11.9 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

…assignment tools Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-07-16T15:03:22Z

@copilot intent is NOT required by default

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-16T15:27:51Z

@copilot intent is NOT required by default

Updated in fda3b45: issue-intent is no longer required by default. Rationale/confidence requirements and INTENT suffix are now opt-in (issue-intent: true) per tool.

Copilot

Pull request overview

Extends safe-output issue-intent metadata to close and assignment tools across schema generation, runtime handlers, typings, tests, and compiled workflows.

Changes:

Adds rationale, confidence, and suggest fields.
Introduces per-tool issue-intent configuration.
Propagates metadata through close and assignment handlers.

Show a summary per file

File	Description
`pkg/workflow/safe_outputs_validation_config.go`	Adds intent validation fields.
`pkg/workflow/safe_outputs_tools_generation.go`	Generates required intent fields.
`pkg/workflow/safe_outputs_tools_generation_test.go`	Tests required-field generation.
`pkg/workflow/safe_outputs_handler_registry.go`	Serializes intent configuration.
`pkg/workflow/safe_outputs_config_types.go`	Defines the per-tool option.
`pkg/workflow/safe_output_validation_config_test.go`	Expands validation tests.
`pkg/workflow/js/safe_outputs_tools.json`	Updates static tool schemas.
`actions/setup/js/types/safe-outputs.d.ts`	Extends safe-output typings.
`actions/setup/js/safe_outputs_tools.json`	Updates runtime tool schemas.
`actions/setup/js/generate_safe_outputs_tools.test.cjs`	Tests dynamic descriptions.
`actions/setup/js/generate_safe_outputs_tools.cjs`	Applies intent guidance.
`actions/setup/js/close_issue.test.cjs`	Tests close metadata behavior.
`actions/setup/js/close_issue.cjs`	Sends close intent metadata.
`actions/setup/js/assign_to_user.test.cjs`	Tests user-assignment metadata.
`actions/setup/js/assign_to_user.cjs`	Sends assignment metadata.
`actions/setup/js/assign_to_agent.cjs`	Propagates agent-assignment metadata.
`actions/setup/js/assign_agent_helpers.test.cjs`	Tests agent helper metadata.
`actions/setup/js/assign_agent_helpers.cjs`	Sends agent intent metadata.
`.github/workflows/workflow-generator.lock.yml`	Recompiles assignment schema.
`.github/workflows/smoke-copilot.lock.yml`	Recompiles intent requirements.
`.github/workflows/smoke-copilot-aoai-entra.lock.yml`	Recompiles intent requirements.
`.github/workflows/smoke-copilot-aoai-apikey.lock.yml`	Recompiles intent requirements.
`.github/workflows/smoke-codex.lock.yml`	Recompiles intent requirements.
`.github/workflows/smoke-agent-public-approved.lock.yml`	Recompiles assignment schema.
`.github/workflows/semantic-function-refactor.lock.yml`	Recompiles close schema.
`.github/workflows/objective-impact-report.lock.yml`	Recompiles close schema.
`.github/workflows/lint-monster.lock.yml`	Recompiles close/assignment schemas.
`.github/workflows/issue-monster.lock.yml`	Recompiles assignment schema.
`.github/workflows/eslint-monster.lock.yml`	Recompiles close/assignment schemas.
`.github/workflows/dependabot-go-checker.lock.yml`	Recompiles close schema.
`.github/workflows/daily-assign-issue-to-user.lock.yml`	Recompiles user-assignment schema.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 30/31 changed files
Comments generated: 6
Review effort level: Medium

Copilot · 2026-07-16T18:18:55Z

 	GitHubToken              string           `yaml:"github-token,omitempty"`               // GitHub token for this specific output type
 	GitHubApp                *GitHubAppConfig `yaml:"github-app,omitempty"`                 // GitHub App credentials for minting a per-handler installation access token
 	Staged                   *TemplatableBool `yaml:"staged,omitempty"`                     // Templatable preview-only mode for this specific output type
+	IssueIntent              *bool            `yaml:"issue-intent,omitempty"`               // When true, enable issue-intent rationale/confidence guidance and schema requirements for this output type.


Fixed in e41a65c: issue-intent is now accepted in main_workflow_schema.json for close-issue, assign-to-user, and assign-to-agent, and covered by schema tests.

Copilot · 2026-07-16T18:18:55Z

+func issueIntentRequired(issueIntent *bool) bool {
+	return issueIntent != nil && *issueIntent
+}


Addressed in 739c45a: behavior is now maintainer-aligned — unset issue_intent keeps intent fields optional, true makes them required, and false omits them.

Copilot · 2026-07-16T18:18:55Z

+function isIssueIntentEnabledForTool(toolName, toolConfig) {
+  if (!ISSUE_INTENT_TOOL_NAMES.has(toolName)) {
+    return false;
+  }
+  return !!(toolConfig && typeof toolConfig === "object" && "issue_intent" in toolConfig && toolConfig.issue_intent === true);
+}


Addressed in 739c45a: generator logic now models three states for intent fields (required/optional/absent) based on issue_intent value, with unset treated as optional.

Copilot · 2026-07-16T18:18:55Z

 			AddTemplatableInt("max", c.Max).
 			AddStringSlice("allowed", c.Allowed).
 			AddStringSlice("blocked", c.Blocked).
+			AddBoolPtr("issue_intent", c.IssueIntent).


Fixed in e41a65c: add_labels.cjs now honors config.issue_intent; metadata normalization/forwarding happens only when explicitly enabled.

Copilot · 2026-07-16T18:18:55Z

 		config := newHandlerConfigBuilder().
 			AddTemplatableInt("max", c.Max).
 			AddStringSlice("allowed", c.Allowed).
+			AddBoolPtr("issue_intent", c.IssueIntent).


Fixed in e41a65c (with header cleanup in 739c45a): set_issue_type.cjs now reads config.issue_intent and uses legacy behavior when disabled.

Copilot · 2026-07-16T18:18:55Z

 		config := newHandlerConfigBuilder().
 			AddTemplatableInt("max", c.Max).
 			AddStringSlice("allowed_fields", c.AllowedFields).
+			AddBoolPtr("issue_intent", c.IssueIntent).


Fixed in e41a65c (with follow-up 326a94d/739c45a): set_issue_field.cjs now gates issue-intent metadata on config.issue_intent and keeps legacy behavior when disabled.

pelikhan · 2026-07-16T16:10:51Z

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-16T16:36:56Z

@copilot run pr-finisher skill

Done. I ran the PR-finisher flow, triaged reviews/checks/mergeability, and pushed fix 89813ab to address the failing JS typecheck (close_issue.cjs TS1016).

gh-aw-bot · 2026-07-16T16:37:57Z

@copilot please run the pr-finisher skill, address unresolved review feedback, and rerun checks once the branch is up to date.

Failed checks:

js-typecheck: https://github.com/github/gh-aw/actions/runs/29514461506/job/87675865931
impacted-js-tests: https://github.com/github/gh-aw/actions/runs/29514461506/job/87675866040
agent: https://github.com/github/gh-aw/actions/runs/29514461370/job/87676340487

Generated by 👨‍🍳 PR Sous Chef · 9.89 AIC · ⌖ 7.32 AIC · ⊞ 5.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

gh-aw-bot · 2026-07-16T17:51:10Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks once the branch is up to date.

Unresolved review threads:

copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)
copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)
copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)
copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)
copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)
copilot-pull-request-reviewer: Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out #46014 (comment)

Generated by 👨‍🍳 PR Sous Chef · 15.2 AIC · ⌖ 11.9 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-16T18:00:29Z

@copilot

query graphql feature flag is not needed anymore...

Addressed in 739c45a (plus follow-ups 326a94d, bf829dc). I removed the GraphQL-Features: update_issue_suggestions header injection from the issue-intent runtime paths touched here, and updated MCP tool generation so intent fields are:

required when issue_intent: true
optional when issue_intent is unset
absent when issue_intent: false

Focused tests were updated and passing for the modified handlers/schema generator.

Copilot · 2026-07-16T18:24:15Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks once the branch is up to date.

Unresolved review threads:...

Completed.

Replied on all six unresolved review threads and mapped each to the fixing commits (e41a65c, 739c45a, 326a94d).
Verified the previously failing checks are green on the latest CJS rerun (29522085612, run attempt 2): js-typecheck and impacted-js-tests both passed.
Re-triaged PR state: mergeable is now clean.

Note: local full-suite targets (make test-unit / make test) still report unrelated pre-existing pkg/cli failures in this environment (hostname/timeout-sensitive tests), while targeted issue-intent Go/JS tests and JS typecheck pass.

github-actions · 2026-07-16T19:58:04Z

🎉 This pull request is included in a new release.

Release: v0.82.11

Initial plan

892d563

Copilot AI assigned Copilot and pelikhan Jul 16, 2026

Copilot AI linked an issue Jul 16, 2026 that may be closed by this pull request

Require rationale/confidence for close and assignment tools with an issue-intents opt-out #43175

Closed

Copilot started work on behalf of pelikhan July 16, 2026 14:30 View session

feat(safe-outputs): add issue-intent metadata controls for close and …

33db64b

…assignment tools Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Extend issue-intent metadata for close and assignment tools~~ Require issue-intent metadata for close/assignment tools by default, with per-tool opt-out Jul 16, 2026

Copilot AI requested a review from pelikhan July 16, 2026 15:03

Copilot finished work on behalf of pelikhan July 16, 2026 15:03

Copilot started work on behalf of pelikhan July 16, 2026 15:03 View session

Copilot AI and others added 2 commits July 16, 2026 15:09

Plan: address issue-intent default behavior feedback

03a152b

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

fix(safe-outputs): make issue-intent requirements opt-in

fda3b45

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 16, 2026 15:28

Merge branch 'main' into copilot/require-rationale-confidence-tools

c7c0b66

pelikhan marked this pull request as ready for review July 16, 2026 15:45

Copilot AI review requested due to automatic review settings July 16, 2026 15:45

Copilot started reviewing on behalf of pelikhan July 16, 2026 15:46 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

Merge branch 'main' into copilot/require-rationale-confidence-tools

6711153

Copilot started work on behalf of pelikhan July 16, 2026 16:11 View session

Fix close_issue JSDoc param ordering for typecheck

89813ab

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot mentioned this pull request Jul 16, 2026

[pr-sous-chef] Run report — 0 nudged, 9 skipped #45855

Closed

Copilot finished work on behalf of pelikhan July 16, 2026 16:38

Copilot started work on behalf of gh-aw-bot July 16, 2026 16:38 View session

chore: start PR finisher triage plan

900f2e1

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot started work on behalf of pelikhan July 16, 2026 17:32 View session

Merge branch 'main' into copilot/require-rationale-confidence-tools

58c3fec

Copilot AI and others added 3 commits July 16, 2026 17:57

fix: remove intent feature header and enforce intent schema states

739c45a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

style: fix GraphQL mutation indentation in set_issue_field

326a94d

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

docs: clarify required-array normalization in schema helper

bf829dc

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 16, 2026 18:02

Copilot started work on behalf of gh-aw-bot July 16, 2026 18:03 View session

Copilot finished work on behalf of gh-aw-bot July 16, 2026 18:25

github-actions Bot added pr-action:fast_track pr-agent:copilot pr-priority:medium pr-risk:high pr-type:feature pr-batch:large-features labels Jul 16, 2026

pelikhan merged commit 813bbd0 into main Jul 16, 2026
38 checks passed

pelikhan deleted the copilot/require-rationale-confidence-tools branch July 16, 2026 18:51

This was referenced Jul 16, 2026

Smoke Test: MAI-Code-1-Flash - 29538613340 #46092

Closed

Smoke Test: MAI-Code-1-Flash - 29562782974 #46167

Closed

alondahari mentioned this pull request Jul 17, 2026

Require rationale/confidence by default with an issue-intents opt-out #44535

Closed

Copilot AI mentioned this pull request Jul 17, 2026

Refresh stale package specs and add linters doc drift guard #46257

Merged

github-actions Bot mentioned this pull request Jul 17, 2026

[gh-aw-upgrade] gh-aw upgrade available: v0.80.9 → v0.82.12 elastic/ai-github-actions#1596

Open

5 tasks

Uh oh!

Conversation

Copilot AI commented Jul 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

gh-aw-bot commented Jul 16, 2026

Uh oh!

gh-aw-bot commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

Copilot AI commented Jul 16, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 16, 2026 •

edited by github-actions Bot

Loading