Unshadow package logger identifiers to restore rawloginlib detection#45637
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Un-shadow stdlib log in six files for linter coverage
Unshadow package logger identifiers to restore Jul 15, 2026
rawloginlib detection
pelikhan
marked this pull request as ready for review
July 15, 2026 05:52
Contributor
There was a problem hiding this comment.
Pull request overview
Renames package logger variables to pkgLog, restoring reliable rawloginlib analysis without behavior changes.
Changes:
- Renames logger identifiers and all associated call sites across six Go files.
- Includes unrelated trailing-whitespace changes in four generated workflow lockfiles.
Show a summary per file
| File | Description |
|---|---|
pkg/modelsdev/catalog.go |
Renames the catalog logger. |
pkg/linters/largefunc/largefunc.go |
Renames the linter logger. |
pkg/linters/deferinloop/deferinloop.go |
Renames the linter logger. |
pkg/linters/httprespbodyclose/httprespbodyclose.go |
Renames the linter logger. |
pkg/linters/httpstatuscode/httpstatuscode.go |
Renames the linter logger. |
pkg/linters/excessivefuncparams/excessivefuncparams.go |
Renames the linter logger. |
.github/workflows/smoke-claude.lock.yml |
Adds unrelated trailing whitespace. |
.github/workflows/issue-monster.lock.yml |
Adds unrelated trailing whitespace. |
.github/workflows/deep-report.lock.yml |
Adds unrelated trailing whitespace. |
.github/workflows/dataflow-pr-discussion-dataset.lock.yml |
Adds unrelated trailing whitespace. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/10 changed files
- Comments generated: 6
- Review effort level: Medium
| 6. **File Writing Testing**: Create a test file `/tmp/gh-aw/agent/smoke-test-claude-__GH_AW_GITHUB_RUN_ID__.txt` with content "Smoke test passed for Claude at $(date)" (create the directory if it doesn't exist) | ||
| 7. **Bash Tool Testing**: Execute bash commands to verify file creation was successful (use `cat` to read the file back) | ||
| 8. **Discussion Interaction Testing**: | ||
| 8. **Discussion Interaction Testing**: |
| - After submitting, use the GitHub MCP tool to list review threads on the PR and note the thread IDs from review comments you created in test #14 — these will be used in test #16 | ||
|
|
||
| 16. **Resolve Review Thread Testing**: | ||
| 16. **Resolve Review Thread Testing**: |
| - Note: May fail if reviewer is already assigned or doesn't have access | ||
|
|
||
| 18. **Push to PR Branch Testing**: | ||
| 18. **Push to PR Branch Testing**: |
Comment on lines
+2286
to
+2287
| const openCopilotPRs = issue.linkedPRs?.filter(pr => | ||
| pr.state === 'OPEN' && |
| # Extract discussions and normalize structure | ||
| echo "$RESULT" | jq -r ' | ||
| .data.repository.discussions.nodes | ||
| .data.repository.discussions.nodes |
| # Extract discussions and normalize structure | ||
| echo "$RESULT" | jq -r ' | ||
| .data.repository.discussions.nodes | ||
| .data.repository.discussions.nodes |
Contributor
|
🎉 This pull request is included in a new release. Release: |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six packages declared
var log = logger.New(...), shadowing the stdliblogidentifier and preventingrawloginlibfrom reliably detecting raw stdlib logging usage in those files. This change performs a mechanical rename to remove that shadowing and re-enable coverage.Scope
pkg/linters/largefunc/largefunc.gopkg/linters/deferinloop/deferinloop.gopkg/linters/httprespbodyclose/httprespbodyclose.gopkg/linters/httpstatuscode/httpstatuscode.gopkg/linters/excessivefuncparams/excessivefuncparams.gopkg/modelsdev/catalog.goCode changes
logtopkgLog.log.Printf(...)→pkgLog.Printf(...)).Representative diff pattern