feat(formal-spec): add PRECOND_BlockedUsersRequireMinIntegrity to access-control formal model

[Copilot]

The behavioral coverage map in specs/github-mcp-access-control-compliance/README.md was missing the PRECOND_BlockedUsersRequireMinIntegrity predicate — the validation rule that blocked-users requires min-integrity to be set — leaving the 15-predicate table from the issue incomplete and the precondition untested in the formal suite.

Changes

• pkg/workflow/github_mcp_access_control_formal_test.go

  • Added formalValidateConfig — in-test mini-validator mirroring the compile-time precondition for formalToolConfig, consistent with the existing formalEvaluateAccess pattern
  • Added TestFormal_BlockedUsersRequireMinIntegrity covering three cases: missing min-integrity errors, valid config with both fields set, and empty blocked-users (guard inactive, no error)

• specs/github-mcp-access-control-compliance/README.md

  • Added PRECOND_BlockedUsersRequireMinIntegrity row to the behavioral coverage map, completing the full 15-predicate table

func formalValidateConfig(cfg formalToolConfig) error {
    if len(cfg.BlockedUsers) > 0 && cfg.MinIntegrity == "" {
        return errors.New("invalid guard policy: blocked-users requires min-integrity to be set")
    }
    return nil
}

[github-actions]

🤖 PR Triage

Field	Value
Category	test
Risk	low
Priority Score	45/100
Score Breakdown	impact: 20, urgency: 10, quality: 15
Action	batch_review

Adds PRECOND_BlockedUsersRequireMinIntegrity formal test + spec README. 2 files, +37/-0. Draft, CI unknown. Additive test/docs. Candidate for batch review with other formal-spec test PRs.

Generated by 🔧 PR Triage Agent · 142.9 AIC · ⌖ 7.2 AIC · ⊞ 5.6K · ◷

[Copilot]

Pull request overview

Adds formal-model coverage for the blocked-users/min-integrity precondition.

Changes:

• Adds a formal validator and three validation scenarios.
• Adds the predicate to the compliance coverage map.
• Requires reconciliation with the linked normative specification.

Show a summary per file

File	Description
pkg/workflow/github_mcp_access_control_formal_test.go	Adds precondition modeling and tests.
specs/github-mcp-access-control-compliance/README.md	Documents the new predicate coverage.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Medium