Skip to content

refactor: migrate deprecated RequiredSubcommand and GetGeminiAPITarget callsites to canonical forms #44717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Jul 10, 2026
Merged

refactor: migrate deprecated RequiredSubcommand and GetGeminiAPITarget callsites to canonical forms #44717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2f7286
Initial plan
Copilot Jul 10, 2026
5b2a1fd
refactor: migrate deprecated RequiredSubcommand and GetGeminiAPITarge…
Copilot Jul 10, 2026
acba473
Merge branch 'main' into copilot/deep-report-migrate-deprecated-calls
github-actions[bot] Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/workflow/awf_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,6 @@ func BuildAWFConfigJSON(config AWFCommandConfig) (string, error) {
if antigravityTarget := GetAntigravityAPITarget(config.WorkflowData, config.EngineName); antigravityTarget != "" {
// Route the Antigravity-resolved API target through the "gemini" provider key
// to match AWF's supported target providers.
geminiTarget := GetGeminiAPITarget(config.WorkflowData, config.EngineName)
if geminiTarget != "" && geminiTarget != antigravityTarget {
awfConfigLog.Printf("API proxy: overriding gemini target %s with antigravity target %s; configure only one of GEMINI_API_BASE_URL or ANTIGRAVITY_API_BASE_URL to avoid ambiguity", geminiTarget, antigravityTarget)
}
awfConfigLog.Printf("API proxy: mapped antigravity target to gemini provider target=%s", antigravityTarget)
targets["gemini"] = &AWFAPITargetConfig{Host: antigravityTarget}
} else if geminiTarget := GetGeminiAPITarget(config.WorkflowData, config.EngineName); geminiTarget != "" {
Expand Down
5 changes: 2 additions & 3 deletions pkg/workflow/npm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@ func extractNpxPackages(workflowData *WorkflowData) []string {
// extractNpxFromCommands extracts npx package names from command strings
func extractNpxFromCommands(commands string) []string {
extractor := PackageExtractor{
CommandNames: []string{"npx"},
RequiredSubcommand: "",
TrimSuffixes: "&|;",
CommandNames: []string{"npx"},
TrimSuffixes: "&|;",
}
return extractor.ExtractPackages(commands)
}
11 changes: 5 additions & 6 deletions pkg/workflow/pip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ func extractPipPackages(workflowData *WorkflowData) []string {
// extractPipFromCommands extracts pip package names from command strings
func extractPipFromCommands(commands string) []string {
extractor := PackageExtractor{
CommandNames: []string{"pip", "pip3"},
RequiredSubcommand: "install",
TrimSuffixes: "&|;",
CommandNames: []string{"pip", "pip3"},
RequiredSubcommands: []string{"install"},
TrimSuffixes: "&|;",
}
return extractor.ExtractPackages(commands)
}
Expand All @@ -68,9 +68,8 @@ func extractUvFromCommands(commands string) []string {
lines := strings.Split(commands, "\n")

uvxExtractor := PackageExtractor{
CommandNames: []string{"uvx"},
RequiredSubcommand: "",
TrimSuffixes: "&|;",
CommandNames: []string{"uvx"},
TrimSuffixes: "&|;",
}

uvPipHelper := PackageExtractor{TrimSuffixes: "&|;"}
Expand Down
Loading