Add init command regression coverage for custom agent creation #44656
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,6 +180,47 @@ func TestInitCommandInteractiveModeDetection(t *testing.T) { | |
| } | ||
| } | ||
|
|
||
| func TestInitCommandCreatesCustomAgentByDefault(t *testing.T) { | ||
| tmpDir := testutil.TempDir(t, "test-*") | ||
|
|
||
| originalDir, err := os.Getwd() | ||
| if err != nil { | ||
| t.Fatalf("Failed to get current directory: %v", err) | ||
| } | ||
| defer func() { | ||
| _ = os.Chdir(originalDir) | ||
| }() | ||
|
|
||
| if err := os.Chdir(tmpDir); err != nil { | ||
| t.Fatalf("Failed to change to temp directory: %v", err) | ||
| } | ||
|
|
||
| if err := exec.Command("git", "init").Run(); err != nil { | ||
| t.Skip("Git not available") | ||
| } | ||
|
Comment on lines
+198
to
+200
|
||
| if err := exec.Command("git", "config", "user.name", "Test User").Run(); err != nil { | ||
| t.Fatalf("Failed to set git user.name: %v", err) | ||
| } | ||
| if err := exec.Command("git", "config", "user.email", "test@example.com").Run(); err != nil { | ||
| t.Fatalf("Failed to set git user.email: %v", err) | ||
| } | ||
|
|
||
| cmd := NewInitCommand() | ||
|
Contributor
There was a problem hiding this comment. [/tdd] The PR description says this guards against flag wiring regressions, but only the positive case (default path creates the agent) is tested — the inverse is missing. 💡 Suggested inverse testAdd a companion test that passes cmd := NewInitCommand()
cmd.SetArgs([]string{"--no-agent"})
if err := cmd.Execute(); err != nil {
t.Fatalf("init command failed: %v", err)
}
agentPath := filepath.Join(".github", "agents", "agentic-workflows.md")
if _, err := os.Stat(agentPath); !os.IsNotExist(err) {
t.Error("Expected --no-agent to suppress custom agent file creation")
}Without this, the flag wiring can silently break in the other direction (e.g., @copilot please address this. |
||
| cmd.SetArgs([]string{}) | ||
| if err := cmd.Execute(); err != nil { | ||
| t.Fatalf("init command failed: %v", err) | ||
| } | ||
|
|
||
| agentPath := filepath.Join(".github", "agents", "agentic-workflows.md") | ||
| agentContent, err := os.ReadFile(agentPath) | ||
| if err != nil { | ||
| t.Fatalf("Expected Agentic Workflows custom agent file to be created at %s: %v", agentPath, err) | ||
| } | ||
| if !strings.Contains(string(agentContent), "name: Agentic Workflows") { | ||
| t.Error("Expected Agentic Workflows custom agent file to use the Agentic Workflows name") | ||
| } | ||
|
Comment on lines
+219
to
+221
|
||
| } | ||
|
|
||
| func TestInitRepositoryBasic(t *testing.T) { | ||
| tmpDir := testutil.TempDir(t, "test-*") | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd] The new test mutates global process state (
os.Chdir) withoutt.Parallel(), while several sibling tests do run in parallel — this creates a race condition if the Go test runner schedules them concurrently.💡 Why this matters and how to fix it
Tests that call
os.Chdirchange the working directory for the entire process, not just the current goroutine. If two such tests run concurrently one will silently operate in the wrong directory.The safest fix is to not use
os.Chdirat all. Pass the working directory explicitly to the command, or uset.Chdir(tmpDir)(Go 1.24+) which automatically serialises directory changes and restores on cleanup.If the command API requires the cwd to be implicit, mark the test with a serial-safe pattern or accept that the suite must run with
-p 1.Existing tests in this file (
TestInitRepositoryBasic, etc.) follow the sameos.Chdirpattern, so this is a pre-existing issue — but the new test should not perpetuate it without a comment.@copilot please address this.