Fix yamllint violations in generated lock files by Copilot · Pull Request #44491 · github/gh-aw

Copilot · 2026-07-09T05:29:48Z

The Daily yamllint Fixer workflow was hitting ~410 yamllint violations (62 errors) in generated *.lock.yml files, stemming from four distinct bugs in the Go compiler. This PR fixes the root causes rather than patching the generated output.

Bugs fixed

trigger_parser.go / tools.go — missing IndentSequence(true)
yaml.Marshal was used (instead of yaml.MarshalWithOptions(..., yaml.IndentSequence(true))) when re-marshaling the on: section for workflows with reaction/status-comment/stop-after triggers and for slash_command/label_command event merging. Sequence items under types: and schedule: appeared at the same indent as their parent key, violating yamllint's indentation rule.
```
// Before
onEventsYAML, err := yaml.Marshal(map[string]any{"on": otherEvents})
// After
onEventsYAML, err := yaml.MarshalWithOptions(map[string]any{"on": otherEvents}, yaml.IndentSequence(true))
```
schedule_preprocessing.go — misaligned "Friendly format" comments
Friendly schedule comments were emitted on a separate line with deeper indentation than the following non-comment content, triggering yamllint's comments-indentation rule (~350 warnings). Fixed by appending the comment inline on the cron line.
compiler_main_job.go — permissions indentation not normalized after RenderToYAML()
In the needsContentsRead block, perms.RenderToYAML() (6-space indent) was assigned directly to permissions without re-normalizing to 2-space via filterJobLevelPermissions. Subsequent indentYAMLLines(permissions, " ") then produced 10-space-indented permission values instead of the expected 6, affecting workflows that had explicit permissions but no contents: read.

Impact

	Errors	Warnings	Total
Before	62	348	410
After	16	211	227

The 16 remaining errors are pre-existing trailing spaces inside embedded jq/shell heredocs in specific workflow markdown files — not generator bugs.

All 260 workflows recompiled successfully. Test assertions and the smoke-copilot wasm golden file updated to match the corrected YAML indentation.

- trigger_parser.go: use yaml.MarshalWithOptions with IndentSequence(true) for `on:` section when reaction/status-comment/stop-after triggers present - tools.go: same fix for slash_command and label_command event merging - schedule_preprocessing.go: move Friendly format comment inline on cron line instead of a separate next line (fixes comments-indentation warnings) - compiler_main_job.go: normalize RenderToYAML() output through filterJobLevelPermissions in needsContentsRead block (fixes expected 6 but found 10 indentation errors for workflows missing contents:read) - Update test assertions to match new IndentSequence(true) output - Update wasm golden file for smoke-copilot - Recompile all 260 lock files Before: 410 yamllint violations (62 errors, 348 warnings) After: 227 yamllint violations (16 errors, 211 warnings) Remaining 16 errors are pre-existing in embedded jq/shell scripts Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes several YAML generation issues in the gh aw workflow compiler that were causing widespread yamllint violations in generated *.lock.yml files, and then regenerates affected lockfiles and goldens to match the corrected output.

Changes:

Normalize sequence indentation under the on: section by using yaml.MarshalWithOptions(..., yaml.IndentSequence(true)) in additional re-marshaling paths.
Emit “Friendly format” schedule comments inline on the cron line to avoid comments-indentation violations.
Normalize job-level permissions indentation after RenderToYAML() so the final rendered workflow YAML aligns correctly.

Show a summary per file

File	Description
pkg/workflow/trigger_parser.go	Uses `IndentSequence(true)` when re-marshaling `on:` for certain trigger combinations to avoid invalid sequence indentation.
pkg/workflow/tools.go	Uses `IndentSequence(true)` when marshalling merged command/label-command `on:` event maps so `types:` lists indent correctly.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden	Updates wasm golden output to reflect inline schedule comments / indentation fixes.
pkg/workflow/schedule_preprocessing.go	Moves friendly schedule comments onto the cron line to satisfy yamllint comment indentation rules.
pkg/workflow/label_command_test.go	Updates assertions to match the corrected `types:` list indentation in generated YAML.
pkg/workflow/compiler_main_job.go	Re-normalizes permissions YAML after `RenderToYAML()` to prevent over-indentation in rendered jobs.
pkg/workflow/compiler_events_test.go	Updates expected `on:` YAML strings to match corrected sequence indentation.
.github/workflows/workflow-skill-extractor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/workflow-normalizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/workflow-health-manager.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/workflow-generator.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation.
.github/workflows/weekly-safe-outputs-spec-review.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/weekly-issue-summary.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement and permissions indentation.
.github/workflows/weekly-editors-health-check.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/weekly-blog-post-writer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/update-astro.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/unbloat-docs.lock.yml	Regenerated lockfile reflecting corrected schedule list indentation.
.github/workflows/uk-ai-operational-resilience.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/ubuntu-image-analyzer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/typist.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/tidy.lock.yml	Regenerated lockfile reflecting corrected sequence indentation under `push:` and `schedule:`.
.github/workflows/test-quality-sentinel.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation.
.github/workflows/terminal-stylist.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/super-linter.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/sub-issue-closer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/step-name-alignment.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/static-analysis-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/stale-pr-cleanup.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/spec-librarian.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/spec-extractor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/spec-enforcer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/smoke-update-cross-repo-pr.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-test-tools.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-temporary-id.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-project.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-pi.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-opencode.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-multi-pr.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-gemini.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-crush.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-create-cross-repo-pr.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-copilot-sub-agents.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/smoke-copilot-arm.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-codex.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-claude.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-ci.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/smoke-call-workflow.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-antigravity.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-agent-scoped-approved.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-agent-public-none.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-agent-public-approved.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-agent-all-none.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/smoke-agent-all-merged.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/slide-deck-maintainer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/sergo.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/semantic-function-refactor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/scout.lock.yml	Regenerated lockfile reflecting corrected commented-list indentation under `roles:` and input `options:` sequences.
.github/workflows/schema-feature-coverage.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/schema-consistency-checker.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/safe-output-health.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/repository-quality-improver.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/repo-tree-map.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/refactoring-cadence.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/q.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and commented-list indentation under `roles:`.
.github/workflows/prompt-clustering-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/pr-triage-agent.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/pr-sous-chef.lock.yml	Regenerated lockfile reflecting corrected schedule list indentation.
.github/workflows/pr-code-quality-reviewer.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation.
.github/workflows/poem-bot.lock.yml	Regenerated lockfile reflecting corrected commented-list indentation under `roles:`.
.github/workflows/outcome-collector.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/org-health-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/metrics-collector.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/mcp-inspector.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/mattpocock-skills-reviewer.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation.
.github/workflows/lockfile-stats.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/linter-miner.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/lint-monster.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/layout-spec-maintainer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/jsweep.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/issue-triage-agent.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement and permissions indentation.
.github/workflows/issue-monster.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/issue-arborist.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/instructions-janitor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/gpclean.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/go-pattern-detector.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/go-logger.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/go-fan.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/glossary-maintainer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/github-remote-mcp-auth-test.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/github-mcp-tools-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/github-mcp-structural-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/firewall-escape.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/example-workflow-analyzer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/eslint-refiner.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/eslint-monster.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/eslint-miner.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/duplicate-code-detector.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/draft-pr-cleanup.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/docs-noob-tester.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/discussion-task-miner.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/dictation-prompt.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/developer-docs-consolidator.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/dev.lock.yml	Regenerated lockfile reflecting corrected schedule list indentation.
.github/workflows/detection-analysis-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/designer-drift-audit.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/design-decision-gate.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/dependabot-burner.lock.yml	Regenerated lockfile reflecting corrected schedule list indentation and commented-list indentation under `roles:`.
.github/workflows/delight.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/deep-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/dead-code-remover.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/dataflow-pr-discussion-dataset.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-yamllint-fixer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-workflow-updater.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-windows-terminal-integration-builder.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-token-consumption-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-testify-uber-super-expert.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-team-status.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-team-evolution-insights.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-syntax-error-quality.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-spdd-spec-planner.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-skill-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-sentrux-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-semgrep-scan.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-security-red-team.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-security-observability.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-secrets-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-safeoutputs-git-simulator.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-safe-outputs-conformance.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-safe-output-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-safe-output-integrator.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-repo-chronicle.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-rendering-scripts-verifier.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-reliability-review.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-regulatory.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-performance-summary.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-observability-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-news.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-multi-device-docs-tester.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-model-resolution.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-model-inventory.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-mcp-concurrency-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-max-ai-credits-test.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-malicious-code-scan.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-issues-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-hippo-learn.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-geo-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-function-namer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-formal-spec-verifier.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-firewall-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-file-diet.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-fact.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-experiment-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-elixir-credo-snippet-audit.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-doc-updater.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-doc-healer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-credit-limit-test.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-compiler-threat-spec-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-compiler-quality.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-community-attribution.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-code-metrics.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-cli-tools-tester.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-cli-performance.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-choice-test.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-caveman-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-cache-strategy-analyzer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-byok-ollama-test.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-awf-spec-compiler-surfacing.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-aw-cross-repo-compile-check.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-assign-issue-to-user.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-architecture-diagram.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-ambient-context-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-agentrx-trace-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/daily-agent-of-the-day-blog-writer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-session-insights.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-pr-prompt-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-pr-nlp-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-pr-merged-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-opt.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-cli-deep-research.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-centralization-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/copilot-agent-analysis.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/contribution-check.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/constraint-solving-potd.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement and permissions indentation.
.github/workflows/code-simplifier.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/code-scanning-fixer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/cli-version-checker.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/cli-consistency-checker.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/claude-code-user-docs-review.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/ci-coach.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/chaos-pr-bundle-fuzzer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/changeset.lock.yml	Regenerated lockfile reflecting corrected `types:` list indentation and comment indentation under `pull_request:`.
.github/workflows/breaking-change-checker.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/bot-detection.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/blog-auditor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/aw-failure-investigator.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/auto-triage-issues.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/audit-workflows.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/artifacts-summary.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/architecture-guardian.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/api-consumption-report.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/agentic-token-optimizer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/agentic-token-audit.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/agent-persona-explorer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/agent-performance-analyzer.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.
.github/workflows/ace-editor.lock.yml	Regenerated lockfile reflecting corrected permissions indentation in rendered jobs.
.github/workflows/ab-testing-advisor.lock.yml	Regenerated lockfile reflecting corrected schedule comment placement / YAML indentation.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 170/207 changed files
Comments generated: 4
Review effort level: Low


 			// Convert merged events to YAML
-			mergedEventsYAML, err := yaml.Marshal(map[string]any{"on": commandEventsMap})
+			mergedEventsYAML, err := yaml.MarshalWithOptions(map[string]any{"on": commandEventsMap}, yaml.IndentSequence(true))



 			// Convert merged events to YAML
-			mergedEventsYAML, err := yaml.Marshal(map[string]any{"on": labelEventsMap})
+			mergedEventsYAML, err := yaml.MarshalWithOptions(map[string]any{"on": labelEventsMap}, yaml.IndentSequence(true))


 	} else if (hasReaction || hasStopAfter || hasStatusComment) && len(otherEvents) > 0 {
 		// Only re-marshal the "on" if we have to
-		onEventsYAML, err := yaml.Marshal(map[string]any{"on": otherEvents})
+		onEventsYAML, err := yaml.MarshalWithOptions(map[string]any{"on": otherEvents}, yaml.IndentSequence(true))


+			// Add friendly format comment inline on the same line as the cron expression.
+			// Placing it on a separate line triggers yamllint's comments-indentation rule
+			// because the comment indentation would differ from the next non-comment line.
 			if friendly, exists := c.scheduleFriendlyFormats[scheduleItemIndex]; exists {
-				// Get the indentation of the cron line
-				indentation := ""
-				if len(line) > len(trimmedLine) {
-					indentation = line[:len(line)-len(trimmedLine)]
-				}
-				// Add comment with friendly format on the next line
-				comment := indentation + "  # Friendly format: " + friendly
-				result = append(result, comment)
+				line = line + "  # Friendly format: " + friendly
 			}
+			result = append(result, line)


github-actions · 2026-07-11T09:03:38Z

🎉 This pull request is included in a new release.

Release: v0.82.8

Initial plan

5b14b05

Copilot AI assigned Copilot and pelikhan Jul 9, 2026

Copilot started work on behalf of pelikhan July 9, 2026 05:32 View session

Copilot AI linked an issue Jul 9, 2026 that may be closed by this pull request

[aw] Daily yamllint Fixer failed #44473

Closed

Copilot AI changed the title ~~[WIP] Fix daily yamllint fixer workflow failure~~ Fix yamllint violations in generated lock files Jul 9, 2026

Copilot finished work on behalf of pelikhan July 9, 2026 06:18

Copilot AI requested a review from pelikhan July 9, 2026 06:18

github-actions Bot added pr-action:fast_track pr-agent:copilot-swe-agent pr-batch:lint-fixes pr-priority:high pr-risk:medium pr-type:bug labels Jul 9, 2026

pelikhan marked this pull request as ready for review July 9, 2026 10:57

Copilot AI review requested due to automatic review settings July 9, 2026 10:57

Copilot started reviewing on behalf of pelikhan July 9, 2026 11:01 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

pelikhan merged commit 261c634 into main Jul 9, 2026
61 of 96 checks passed

pelikhan deleted the copilot/fix-daily-yamllint-fixer branch July 9, 2026 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix yamllint violations in generated lock files#44491

Fix yamllint violations in generated lock files#44491
pelikhan merged 2 commits into
mainfrom
copilot/fix-daily-yamllint-fixer

Copilot AI commented Jul 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bugs fixed

Impact

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

github-actions Bot commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jul 9, 2026 •

edited

Loading