Clarify pr-sous-chef criteria for dismissing github-actions[bot] reviews#43366
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot use safe out to dismiss review, instead of MCP script |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the pr-sous-chef workflow contract/documentation around dismissing github-actions[bot] blocking reviews, and regenerates the compiled workflow lockfile to reflect the safe-outputs/tooling changes.
Changes:
- Replaces the custom
dismiss-github-actions-reviewssafe-output script with the nativedismiss-pull-request-reviewsafe-output configuration and CLI usage. - Tightens the workflow guidance to only dismiss bot
CHANGES_REQUESTEDreviews when all related feedback for that review is resolved. - Regenerates
.github/workflows/pr-sous-chef.lock.ymlto match the updated workflow source.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/pr_sous_chef_workflow_contract_test.go | Updates workflow contract assertions for the new dismissal safe-output/tooling text. |
| .github/workflows/pr-sous-chef.md | Rewords the dismissal contract and switches guidance to the native dismiss-review safe-output tool. |
| .github/workflows/pr-sous-chef.lock.yml | Regenerated compiled workflow reflecting the updated safe-output toolset and config. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
| - For each review ID in that dismissal list, call the native safe-output tool: | ||
| ```bash | ||
| safeoutputs missing_tool --tool "dismiss_pull_request_review" --reason "Need a safe-output to dismiss stale github-actions[bot] CHANGES_REQUESTED reviews after all related comments are addressed." | ||
| safeoutputs dismiss_pull_request_review --pull_request_number 12345 --review_id 4605056464 --justification "Dismissing stale github-actions review because all related review comments appear to be addressed." | ||
| ``` | ||
| Then continue processing the PR normally (do not fail the run solely because dismissal was unavailable). | ||
| - If dismissing one review fails, record the failure and continue with the remaining review IDs; do not fail the entire run solely because one dismissal attempt failed. |
| assert.Contains(t, text, "dismiss-pull-request-review", "Workflow should configure the native safe-output path for dismissing stale github-actions reviews") | ||
| assert.Contains(t, text, "safeoutputs dismiss_pull_request_review", "Workflow should call the native dismiss_pull_request_review safe-output tool") |
|
@copilot please run the Unresolved review feedback to address:
|
…an-triggered runs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed both review threads in the latest commit. Added an explicit Actor guard to step 3 of the workflow that documents |
🤖 PR Triage — Run §28706384347
Score breakdown: impact 38 + urgency 20 + quality 14 Tightens
|
|
@copilot please run the Unresolved review feedback to address:
Run: https://github.com/github/gh-aw/actions/runs/28707474242
|
Both review threads were addressed in commit |
|
@copilot please run the
|
…s-chef-dismiss-review-bot Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Merged latest main (MCP Gateway v0.3.33 and other updates) and recompiled the lockfile. All local validation passes. The review threads were already addressed in the previous commit — CI re-trigger needed for final green checks. |
|
@copilot please
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Committed remaining generated file changes (MCP Gateway v0.3.33 sync in lockfile). All review feedback was addressed in earlier commits. Branch is up to date. Local validation passes — CI re-trigger needed for final green checks. |
|
🎉 This pull request is included in a new release. Release: |
pr-sous-chefshould only dismissgithub-actions[bot]CHANGES_REQUESTEDreviews after the associated feedback is actually resolved. This update tightens the dismissal contract so unresolved bot reviews are preserved instead of being dismissed opportunistically.Behavioral contract update
Selection semantics
github-actions[bot]reviews untouched.Compiled workflow parity
safeoutputs dismiss_github_actions_reviews \ --pull_request_number 12345 \ --review_ids "4605056464,4605057733"