Skip to content

Clarify pr-sous-chef criteria for dismissing github-actions[bot] reviews#43366

Merged
pelikhan merged 6 commits into
mainfrom
copilot/update-pr-sous-chef-dismiss-review-bot
Jul 4, 2026
Merged

Clarify pr-sous-chef criteria for dismissing github-actions[bot] reviews#43366
pelikhan merged 6 commits into
mainfrom
copilot/update-pr-sous-chef-dismiss-review-bot

Conversation

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

pr-sous-chef should only dismiss github-actions[bot] CHANGES_REQUESTED reviews after the associated feedback is actually resolved. This update tightens the dismissal contract so unresolved bot reviews are preserved instead of being dismissed opportunistically.

  • Behavioral contract update

    • Reworded the dismissal rule to require that all related feedback for a review is addressed before dismissal.
    • Made the condition explicit that this applies per review, not broadly per PR.
  • Selection semantics

    • Added guidance to build a dismissal set from only fully-resolved bot reviews.
    • Added an explicit guardrail to leave unresolved github-actions[bot] reviews untouched.
  • Compiled workflow parity

    • Regenerated the corresponding lockfile to reflect the source workflow instruction change.
safeoutputs dismiss_github_actions_reviews \
  --pull_request_number 12345 \
  --review_ids "4605056464,4605057733"

Generated by 👨‍🍳 PR Sous Chef · 8.26 AIC · ⌖ 3.14 AIC · ⊞ 3.4K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · 15.7 AIC · ⌖ 5.01 AIC · ⊞ 3.4K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Update pr-sous-chef github-actions review dismissal criteria Clarify pr-sous-chef criteria for dismissing github-actions[bot] reviews Jul 4, 2026
Copilot AI requested a review from pelikhan July 4, 2026 10:40
@pelikhan

pelikhan commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

@copilot use safe out to dismiss review, instead of MCP script

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot use safe out to dismiss review, instead of MCP script

Updated in 3adffe7. pr-sous-chef now uses the native safe-output path (dismiss-pull-request-review / safeoutputs dismiss_pull_request_review) and no longer uses the custom MCP script for review dismissal.

@github-actions github-actions Bot mentioned this pull request Jul 4, 2026
@pelikhan pelikhan marked this pull request as ready for review July 4, 2026 12:11
Copilot AI review requested due to automatic review settings July 4, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pr-sous-chef workflow contract/documentation around dismissing github-actions[bot] blocking reviews, and regenerates the compiled workflow lockfile to reflect the safe-outputs/tooling changes.

Changes:

  • Replaces the custom dismiss-github-actions-reviews safe-output script with the native dismiss-pull-request-review safe-output configuration and CLI usage.
  • Tightens the workflow guidance to only dismiss bot CHANGES_REQUESTED reviews when all related feedback for that review is resolved.
  • Regenerates .github/workflows/pr-sous-chef.lock.yml to match the updated workflow source.
Show a summary per file
File Description
pkg/cli/pr_sous_chef_workflow_contract_test.go Updates workflow contract assertions for the new dismissal safe-output/tooling text.
.github/workflows/pr-sous-chef.md Rewords the dismissal contract and switches guidance to the native dismiss-review safe-output tool.
.github/workflows/pr-sous-chef.lock.yml Regenerated compiled workflow reflecting the updated safe-output toolset and config.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment on lines +295 to +299
- For each review ID in that dismissal list, call the native safe-output tool:
```bash
safeoutputs missing_tool --tool "dismiss_pull_request_review" --reason "Need a safe-output to dismiss stale github-actions[bot] CHANGES_REQUESTED reviews after all related comments are addressed."
safeoutputs dismiss_pull_request_review --pull_request_number 12345 --review_id 4605056464 --justification "Dismissing stale github-actions review because all related review comments appear to be addressed."
```
Then continue processing the PR normally (do not fail the run solely because dismissal was unavailable).
- If dismissing one review fails, record the failure and continue with the remaining review IDs; do not fail the entire run solely because one dismissal attempt failed.
Comment on lines +36 to +37
assert.Contains(t, text, "dismiss-pull-request-review", "Workflow should configure the native safe-output path for dismissing stale github-actions reviews")
assert.Contains(t, text, "safeoutputs dismiss_pull_request_review", "Workflow should call the native dismiss_pull_request_review safe-output tool")
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address the outstanding review feedback, refresh the branch if needed, and rerun checks once updated.

Unresolved review feedback to address:

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · 8.26 AIC · ⌖ 3.14 AIC · ⊞ 3.4K ·
Comment /souschef to run again

…an-triggered runs

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address the outstanding review feedback, refresh the branch if needed, and rerun checks once updated.

Unresolved review feedback to address:...

Addressed both review threads in the latest commit. Added an explicit Actor guard to step 3 of the workflow that documents dismiss_pull_request_review is actor-bound and requires human-triggered runs (workflow_dispatch / /souschef) to skip dismissal entirely, leaving github-actions[bot] reviews untouched. Updated the contract test to assert both the actor-bound constraint and the human-triggered skip behavior are present in the workflow source.

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Triage — Run §28706384347

Field Value
Category refactor
Risk 🟡 Medium
Score 72 / 100
Action fast_track

Score breakdown: impact 38 + urgency 20 + quality 14

Tightens pr-sous-chef dismissal guard so github-actions[bot] CHANGES_REQUESTED reviews are only dismissed when associated feedback is resolved (+59/-164, 3 files). Approved by @pelikhan. Verify rebase state and merge when ready.

Generated by 🔧 PR Triage Agent · 56.5 AIC · ⌖ 8.62 AIC · ⊞ 5.5K ·

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, confirm the remaining review feedback is resolved, refresh the branch if needed, and rerun checks once updated.

Unresolved review feedback to address:

Run: https://github.com/github/gh-aw/actions/runs/28707474242

Generated by 👨‍🍳 PR Sous Chef · 6.03 AIC · ⌖ 5.73 AIC · ⊞ 3.4K ·
Comment /souschef to run again

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, confirm the remaining review feedback is resolved, refresh the branch if needed, and rerun checks once updated.

Unresolved review feedback to address:...

Both review threads were addressed in commit 138d329 — the actor-bound guardrail is documented in the workflow and the contract test asserts it. No additional changes are needed.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any remaining review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 15.7 AIC · ⌖ 5.01 AIC · ⊞ 3.4K ·
Comment /souschef to run again

Copilot AI and others added 2 commits July 4, 2026 14:15
…s-chef-dismiss-review-bot

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any remaining review feedback, and rerun checks once the branch is up to date.

...

Merged latest main (MCP Gateway v0.3.33 and other updates) and recompiled the lockfile. All local validation passes. The review threads were already addressed in the previous commit — CI re-trigger needed for final green checks.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please
run the pr-finisher skill, address any outstanding review feedback, and rerun checks once the branch is up to date.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · 5.38 AIC · ⌖ 4.28 AIC · ⊞ 3.4K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please
run the pr-finisher skill, address any outstanding review feedback, and rerun checks once the branch is up to date.
...

Committed remaining generated file changes (MCP Gateway v0.3.33 sync in lockfile). All review feedback was addressed in earlier commits. Branch is up to date. Local validation passes — CI re-trigger needed for final green checks.

@pelikhan pelikhan merged commit 953e4f9 into main Jul 4, 2026
20 checks passed
@pelikhan pelikhan deleted the copilot/update-pr-sous-chef-dismiss-review-bot branch July 4, 2026 15:43
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants