-
Notifications
You must be signed in to change notification settings - Fork 445
fix: detect stream_options HTTP 400 as non-retryable Anthropic BYOK error #43127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d2c0530
Initial plan
Copilot 4a2715a
fix: classify stream_options HTTP 400 as non-retryable error for Anth…
Copilot ea44e72
test: add stream_options regression cases to detect_agent_errors.test…
Copilot f60e097
fix: apply Prettier formatting to detect_agent_errors.test.cjs
Copilot 9eb8fd6
Merge branch 'main' into copilot/aw-failures-fix-stream-options
pelikhan beee767
Merge branch 'main' into copilot/aw-failures-fix-stream-options
pelikhan 8106ac5
Merge branch 'main' into copilot/aw-failures-fix-stream-options
pelikhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/tdd]
detect_agent_errors.test.cjsdirectly tests the exportedHTTP_400_RESPONSE_ERROR_PATTERN(lines 185–209), but nostream_optionscases were added there — onlycopilot_harness.test.cjsgot the new coverage. If the two pattern definitions drift in the future, the dedicated test file won't catch it.💡 Suggested additions to
detect_agent_errors.test.cjsAdd a parallel set of cases inside the existing
describe("HTTP_400_RESPONSE_ERROR_PATTERN", ...)block:This mirrors the new cases added to
copilot_harness.test.cjsand directly guards the exported symbol against drift.@copilot please address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in ea44e72 —
detect_agent_errors.test.cjsnow includes both the positive match case and the false-positive guard forstream_options, mirroring the coverage incopilot_harness.test.cjs.