Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/eslint-miner.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions .github/workflows/eslint-miner.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: ESLint Miner
description: Daily workflow that mines JavaScript/TypeScript patterns in actions/setup/js and creates new TypeScript-based ESLint rules in actions/setup/js/eslint-factory
description: Daily workflow that mines JavaScript/TypeScript patterns in actions/setup/js and creates new TypeScript-based ESLint rules in eslint-factory
on:
schedule: daily
workflow_dispatch:
Expand Down Expand Up @@ -47,7 +47,7 @@ safe-outputs:
expires: 7d
if-no-changes: warn
allowed-files:
- "actions/setup/js/eslint-factory/**"
- "eslint-factory/**"
protected-files: fallback-to-issue
noop:
timeout-minutes: 120
Expand Down Expand Up @@ -76,14 +76,14 @@ Out of scope:

1. Mine issues/discussions from the last 14 days for recurring JavaScript/TypeScript failures in `actions/setup/js`.
2. Scan `actions/setup/js` for recurring patterns that should be enforced automatically.
3. Read existing rules in `actions/setup/js/eslint-factory/src/rules`.
3. Read existing rules in `eslint-factory/src/rules`.
4. Choose one net-new rule idea with low false-positive risk.
5. Implement the rule in TypeScript under `actions/setup/js/eslint-factory/src/rules` and register it in `src/index.ts`.
6. Update `actions/setup/js/eslint-factory/eslint.config.cjs` only if needed to enable the new rule.
5. Implement the rule in TypeScript under `eslint-factory/src/rules` and register it in `src/index.ts`.
6. Update `eslint-factory/eslint.config.cjs` only if needed to enable the new rule.
7. Validate with:
- `cd actions/setup/js/eslint-factory && npm install`
- `cd actions/setup/js/eslint-factory && npm run build`
- `cd actions/setup/js/eslint-factory && npm run lint:setup-js`
- `cd eslint-factory && npm install`
- `cd eslint-factory && npm run build`
- `cd eslint-factory && npm run lint:setup-js`
8. Open one draft PR with evidence and rationale.

## Rule quality bar
Expand All @@ -92,7 +92,7 @@ Out of scope:
- Must include a clear diagnostic message.
- Must target behavior observed in `actions/setup/js`.
- Must avoid stylistic-only opinions.
- Must not require changing files outside `actions/setup/js` and `actions/setup/js/eslint-factory`.
- Must not require changing files outside `actions/setup/js` and `eslint-factory`.

## Final action

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/eslint-monster.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/eslint-monster.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ steps:
rm -f /tmp/gh-aw/agent/lint-clean.flag
REPO_ROOT="$(pwd)"

cd actions/setup/js/eslint-factory
cd eslint-factory
npm ci > /tmp/gh-aw/agent/eslint-factory.log 2>&1

if npm run lint:setup-js >> /tmp/gh-aw/agent/eslint-factory.log 2>&1; then
Expand Down
Loading