-
Notifications
You must be signed in to change notification settings - Fork 457
Raise agent sandbox hardening baseline to 50% of eligible workflows #41786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
97b70aa
421694f
62a9d4c
8ece5c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,9 @@ network: | |
| - defaults | ||
| - github | ||
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: false | ||
| tools: | ||
| cli-proxy: true | ||
| cache-memory: true | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,9 @@ engine: | |
|
|
||
| imports: | ||
| - shared/otlp.md | ||
| sandbox: | ||
| agent: | ||
| sudo: false | ||
| tools: | ||
| cli-proxy: true | ||
| github: | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,9 @@ network: | |
| - github | ||
| - python | ||
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: false | ||
| tools: | ||
| cli-proxy: true | ||
| github: | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/improve-codebase-architecture] The
sandbox:block is placed afterimports:here, but in other workflows it is placed afterengine:— inconsistent positioning makes the frontmatter harder to scan at a glance.💡 Suggested convention
Consider adopting a canonical frontmatter ordering for all workflow markdown files, for example:
A consistent slot for
sandbox:means reviewers and automation can locate it predictably across the ~247 eligible workflows. If the compiler enforces an ordering duringmake recompile, this would be resolved automatically.@copilot please address this.