fix(USE-001): add standardized error codes to pr_review_buffer and set_issue_type handlers

[Copilot]

Two safe-output handlers threw errors without standardized error code prefixes, causing USE-001 conformance failures in the daily safe-outputs checker.

Changes

• actions/setup/js/pr_review_buffer.cjs — import ERR_API from error_codes.cjs; prefix the non-transient execution-state capture failure with ERR_API:
• actions/setup/js/set_issue_type.cjs — import ERR_VALIDATION from error_codes.cjs; prefix the invalid confidence value throw with ERR_VALIDATION:

// before
throw new Error(`Failed to capture ${phase} PR review state for #${pullRequestNumber}: ...`);
throw new Error(`Invalid confidence ${JSON.stringify(intentMetadata.confidence)}. Expected one of: LOW, MEDIUM, HIGH.`);

// after
throw new Error(`${ERR_API}: Failed to capture ${phase} PR review state for #${pullRequestNumber}: ...`);
throw new Error(`${ERR_VALIDATION}: Invalid confidence ${JSON.stringify(intentMetadata.confidence)}. Expected one of: LOW, MEDIUM, HIGH.`);

Error codes follow the existing error_codes.cjs registry and the same import/prefix pattern already used across sibling handlers.

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

[Copilot]

Pull request overview

This PR updates two actions/setup/js safe-output handlers to conform with USE-001 by ensuring thrown Error messages begin with standardized error-code prefixes from error_codes.cjs, matching the existing convention used across sibling handlers.

Changes:

• pr_review_buffer.cjs: prefixes the non-transient “capture PR review state” exception with ERR_API:.
• set_issue_type.cjs: prefixes the invalid intentMetadata.confidence exception with ERR_VALIDATION:.

Show a summary per file

File	Description
actions/setup/js/pr_review_buffer.cjs	Imports ERR_API and prefixes the non-transient execution-state capture throw to satisfy standardized error-code requirements.
actions/setup/js/set_issue_type.cjs	Imports ERR_VALIDATION and prefixes the invalid-confidence throw to satisfy standardized error-code requirements.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Low

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #41692 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

[github-actions]

Review: APPROVE

Both changes are correct, minimal, and follow the established codebase pattern.

• ERR_API is the right code for a non-transient GitHub REST API failure in fetchPullRequestReviewState.
• ERR_VALIDATION is the right code for an invalid input value in the confidence switch.

Each file now has exactly one throw new Error and it is properly prefixed. No logic changes, no regression risk.

🔎 Code quality review by PR Code Quality Reviewer · 49.1 AIC · ⌖ 6.84 AIC · ⊞ 5.2K

[github-actions]

Skills-Based Review 🧠

Applied /diagnose and /tdd — commenting with observations (no blocking issues).

📋 Key Themes & Highlights

Key Themes

• Correct fix, right error codes: ERR_API for a GitHub API failure in pr_review_buffer.cjs and ERR_VALIDATION for a bad input value in set_issue_type.cjs both match the error_codes.cjs taxonomy precisely.
• Pattern consistency: Both changes faithfully follow the import-and-prefix pattern already used across sibling handlers — no surprises.
• Missing regression tests: Neither changed error path is exercised by the existing test suites, so a future editor could silently drop a prefix and only the daily checker would notice. See inline comments for suggested tests.

Positive Highlights

• ✅ Minimal, surgical changes — exactly 2 lines of production code altered per file
• ✅ PR description is clear and self-contained with before/after snippets
• ✅ Root cause (two non-compliant throws) is fully addressed, not just symptomised

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 42.9 AIC · ⌖ 7.16 AIC · ⊞ 6.5K

[github-actions]

[/tdd] This fixed error path has no regression test — a future refactor could silently drop the ERR_VALIDATION: prefix and the conformance checker would only catch it in the next daily run.

💡 Suggested test

it("throws ERR_VALIDATION for an unrecognised confidence value", () => {
  const intentMetadata = { confidence: "UNKNOWN" };
  expect(() => toRestIssueIntentMetadata(intentMetadata))
    .toThrow(/^ERR_VALIDATION:/);
});

This keeps the conformance guarantee self-verifying and avoids another USE-001 regression.

[github-actions]

[/tdd] The non-transient error branch (the one just fixed) isn't exercised by any test in pr_review_buffer.test.cjs — so the ERR_API: prefix could regress silently.

💡 Suggested test

it("fetchReviewStateBestEffort rethrows non-transient errors with ERR_API prefix", async () => {
  const nonTransientErr = new Error("quota exceeded");
  mockFetchPullRequestReviewState.mockRejectedValue(nonTransientErr);
  mockIsTransientError.mockReturnValue(false);

  await expect(buffer.fetchReviewStateBestEffort(repoParts, 123, "before"))
    .rejects.toThrow(/^ERR_API:/);
});

Pairs naturally with the existing transient-error path test to give full branch coverage.