[UX] Professionalize Architecture Guardian safe-output status messages

[Copilot]

This updates the architecture-guardian safe-output status text to remove theatrical phrasing, redundant emphasis, and ambiguous failure wording. The workflow now emits clearer, enterprise-friendly run lifecycle messages with better visual triage.

• What changed

  • Updated only the safe-outputs.messages status entries in .github/workflows/architecture-guardian.md:
    • run-started
    • run-success
    • run-failure
  • Replaced failure-state emoji from 🏛️ to ❌ to improve scanability in dashboards.
  • Reworded failure text from “Structure status unknown...” to “Scan did not complete.”

• Compiled workflow alignment

  • Regenerated .github/workflows/architecture-guardian.lock.yml so runtime-safe-output payloads reflect the new message text.

• Updated message block

  run-started: "🏛️ Architecture Guardian scanning code structure on `{event_type}`. [{workflow_name}]({run_url})"
  run-success: "✅ Architecture scan complete. [{workflow_name}]({run_url}) reviewed code structure and delivered a report."
  run-failure: "❌ Architecture scan failed. [{workflow_name}]({run_url}) {status}. Scan did not complete."

[Copilot]

Pull request overview

This PR updates the Architecture Guardian workflow’s safe-output status messaging to be more professional, clearer, and easier to triage, and regenerates the compiled lock file so runtime payloads match.

Changes:

• Reworded run-started, run-success, and run-failure safe-output messages to remove theatrical phrasing and clarify failure semantics.
• Switched the failure-state emoji from 🏛️ to ❌ for better scanability.
• Regenerated .lock.yml so GH_AW_SAFE_OUTPUT_MESSAGES reflects the new message text.

Show a summary per file

File	Description
.github/workflows/architecture-guardian.md	Updates the safe-output status message strings for run started/success/failure.
.github/workflows/architecture-guardian.lock.yml	Updates the generated workflow payload so GH_AW_SAFE_OUTPUT_MESSAGES matches the new message text.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Low

[github-actions]

Hey @app/copilot-swe-agent 👋 — nice cleanup of the architecture-guardian status messages! Removing theatrical phrasing (online!, Structure status unknown...) and swapping the failure emoji to ❌ are exactly the kind of improvements that make dashboards easier to scan at a glance.

One small gap to address before this is fully ready:

• No test coverage — the diff doesn't include any test file changes. For pure YAML message-string edits the test surface is admittedly narrow, but if there are snapshot tests or safe-output message validation tests for this workflow (e.g. in internal/ or a *_test.go fixture), they should be updated to match the new text, or confirmed to be passing as-is.

If you'd like a hand closing that gap, here's a ready-to-use prompt:

Check whether any test files in the repository reference the architecture-guardian safe-output message strings that were changed in PR #41612:
  - Old run-started: "🏛️ Architecture Guardian online! ..."
  - Old run-success: "✅ Architecture scan complete! ... Report delivered! 📋"
  - Old run-failure: "🏛️ Architecture scan failed! ... Structure status unknown..."

Search for these strings (or substrings like "Architecture Guardian online", "Report delivered", "Structure status unknown") in all test files under internal/, pkg/, and any *_test.go files. If matches are found, update them to the new message text introduced in the PR. If no tests reference these strings, add a brief comment to the PR confirming that no test updates are needed.

Generated by ✅ Contribution Check · 313.5 AIC · ⌖ 31.5 AIC · ⊞ 6K · ◷