[avenger] Fix gofmt formatting in compiler_safe_output_jobs.go#40164
Conversation
The previous commit (#40161) left a doc comment in buildSafeOutputsJobs unformatted, which fails CI's fmt-check (make lint). Reformat the comment block to satisfy gofmt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #40164 does not have the 'implementation' label and has only 3 new lines of code in business logic directories (well under the 100-line threshold). |
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped. PR #40164 only modifies pkg/workflow/compiler_safe_output_jobs.go (gofmt formatting fix, +3/-3 lines). |
| // - forwards declared workflow_call inputs in `with:` so worker steps can reference inputs.<name> directly: | ||
| // - non-payload inputs: `fromJSON(needs.safe_outputs.outputs.call_workflow_payload).<name>` | ||
| // - `payload` is forwarded as the raw transport only when the worker declares it | ||
| // (GitHub Actions rejects undeclared inputs) | ||
| // - non-payload inputs: `fromJSON(needs.safe_outputs.outputs.call_workflow_payload).<name>` | ||
| // - `payload` is forwarded as the raw transport only when the worker declares it | ||
| // (GitHub Actions rejects undeclared inputs) |
There was a problem hiding this comment.
✅ No blocking issues
Pure gofmt formatting fix — 3 comment lines de-indented to satisfy fmt-check. No logic, behavior, or correctness changes. The existing inline comment at line 169 already captures the minor documentation hierarchy trade-off. Nothing new to flag.
🔎 Code quality review by PR Code Quality Reviewer · 26.3 AIC · ⌖ 6.82 AIC · ⊞ 5.1K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /zoom-out — change is a pure gofmt compliance fix; LGTM.
📋 Key Themes & Highlights
What Changed
Three doc-comment lines in buildSafeOutputsJobs were re-indented from a nested bullet style (// -) to the standard top-level bullet style (// -) required by gofmt.
Assessment
- ✅ Zero logic change — only whitespace inside a block comment
- ✅ CI unblocked —
make fmt-checknow passes - ✅ Content remains accurate — the bullet describing "forwards declared workflow_call inputs" still flows naturally into the following bullets, which elaborate on the payload handling
No blocking issues; approving.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 36.1 AIC · ⌖ 7.04 AIC · ⊞ 6.9K
Fix gofmt formatting in compiler_safe_output_jobs.go
Summary
Formatting-only change. Three nested bullet lines in the
buildSafeOutputsJobsdoc comment were over-indented, causingmake lint'sfmt-checkstep to fail. Re-aligns them to the standard// -level thatgofmtexpects. No logic, behaviour, or API surface is changed.Changes
pkg/workflow/compiler_safe_output_jobs.gogofmtMotivation
CI (
make lint/fmt-check) was failing due to deeper indentation accidentally used for sub-bullets in thebuildSafeOutputsJobsdoc comment. Minimal fix to unblock CI with no functional impact.Testing
make lintpasses after this change.Risk
None. Pure formatting change inside a comment block.