fix: correct stale 1 MB default for safe-outputs max-patch-size in schema and derived files#39999
Merged
Merged
Conversation
…ze in schema and derived files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
fix: enforce consistent 4096 KB default for safe-outputs max-patch-size
fix: correct stale 1 MB default for safe-outputs max-patch-size in schema and derived files
Jun 18, 2026
Copilot created this pull request from a session on behalf of
pelikhan
June 18, 2026 06:19
View session
pelikhan
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workflow frontmatter JSON schema to reflect the current safe-outputs.max-patch-size default (4096 KB / 4 MB) and regenerates schema-derived documentation artifacts so the published reference materials align with runtime behavior.
Changes:
- Updated
safe-outputs.max-patch-sizeschema description anddefaultfrom1024→4096(KB), and updated the per-output override descriptions to match. - Regenerated the full frontmatter reference doc from the updated schema.
- Regenerated the editor autocomplete dataset from the schema.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/schemas/main_workflow_schema.json | Updates max-patch-size descriptions and the schema default to 4096 KB. |
| docs/public/editor/autocomplete-data.json | Regenerated editor autocomplete data from the schema (includes additional schema-sync deltas). |
| docs/src/content/docs/reference/frontmatter-full.md | Regenerated reference frontmatter template comments to reflect the 4096 KB default. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
Comment on lines
9842
to
+9847
| "max-patch-size": { | ||
| "type": "integer", | ||
| "description": "Maximum allowed size for git patches in kilobytes (KB). Defaults to 1024 KB (1 MB). If patch exceeds this size, the job will fail.", | ||
| "description": "Maximum allowed size for git patches in kilobytes (KB). Defaults to 4096 KB (4 MB). If patch exceeds this size, the job will fail.", | ||
| "minimum": 1, | ||
| "maximum": 10240, | ||
| "default": 1024 | ||
| "default": 4096 |
Comment on lines
545
to
+553
| "models": { | ||
| "type": "object", | ||
| "desc": "Named model alias definitions with ordered fallback lists, resolved recursively by AWF." | ||
| "desc": "Custom model pricing data in the same structure as models.json.", | ||
| "children": { | ||
| "providers": { | ||
| "type": "object", | ||
| "desc": "Provider-keyed map of model pricing data." | ||
| } | ||
| } |
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #39118 raised the
max-patch-sizedefault from 1024 KB to 4096 KB in the runtime code, butmain_workflow_schema.jsonwas not updated — leaving schema descriptions, the"default"annotation, and all derived files claiming the old 1 MB default.Changes
pkg/parser/schemas/main_workflow_schema.json— Updated descriptions and"default"value from1024→4096for three fields:safe-outputs.max-patch-sizesafe-outputs.create-pull-request.max-patch-sizesafe-outputs.push-to-pull-request-branch.max-patch-sizedocs/public/editor/autocomplete-data.json— Regenerated from schema.docs/src/content/docs/reference/frontmatter-full.md— Regenerated from schema.No code logic changed; everything else (
safe_outputs_config.go, handler registry,.github/aw/instruction files, narrative reference docs) was already correct.