Clarify Test Quality Sentinel safe-output comment invocation to prevent Copilot engine permission failures#39867
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Test Quality Sentinel failure
Clarify Test Quality Sentinel safe-output comment invocation to prevent Copilot engine permission failures
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Test Quality Sentinel workflow prompt to ensure the run posts its report via the intended safe-output comment mechanism (rather than invoking safeoutputs from a shell), and regenerates the compiled lockfile to keep it in sync.
Changes:
- Tighten Step 7 instructions in
test-quality-sentinel.mdto require a safe-output-based PR comment emission path and document the expected payload shape. - Regenerate
test-quality-sentinel.lock.ymlto reflect the updated prompt content (body hash).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-quality-sentinel.md | Clarifies the Step 7 comment-posting contract to steer the agent away from shell-based safeoutputs usage. |
| .github/workflows/test-quality-sentinel.lock.yml | Updates compiled workflow metadata to match the modified prompt content. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
| ## Step 7: Post PR Comment with Results | ||
|
|
||
| Post a comment to the pull request with the full analysis using `add-comment`. Use the `tqs-report-template` skill for the exact comment format. | ||
| Post a comment to the pull request with the full analysis using the `add-comment` safe-output tool (tool call, not shell). Use the `tqs-report-template` skill for the exact comment format. |
| {"add_comment":{"body":"<full markdown report>"}} | ||
| ``` | ||
|
|
||
| Do **not** invoke `safeoutputs` from bash, and do **not** set `item_number` for this step. Let `add_comment` auto-target the triggering pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Quality Sentinel failed when the Copilot engine attempted to post its report via shell (
safeoutputs add_comment) and hit a non-interactive permission boundary. This change tightens the workflow prompt so comment posting is executed through the intended safe-output tool path.Prompt contract hardening (
test-quality-sentinel.md)add-comment(not bash/shell invocation).item_numberso targeting stays on the triggering PR context.Compiled workflow update (
test-quality-sentinel.lock.yml){"add_comment":{"body":"<full markdown report>"}}