fix: add git safe.directory and refactor git config to shell script to resolve dubious ownership error by Copilot · Pull Request #39771 · github/gh-aw

Copilot · 2026-06-17T12:12:49Z

The create_pull_request safe output in the Instructions Janitor (and any workflow using create_pull_request) fails when git rejects operations due to "detected dubious ownership in repository" — triggered when the repository directory is owned by a different user than the one executing git commands in the safe_outputs job runner environment.

Changes

actions/setup/sh/configure_git_credentials.sh (new) — canonical POSIX sh-compatible shell script that sets git identity (github-actions[bot]), adds safe.directory from ${GITHUB_WORKSPACE}, and configures the remote URL when all required authentication credentials (GITHUB_REPOSITORY, GITHUB_SERVER_URL, GITHUB_TOKEN/GIT_TOKEN) are present. Auth is silently skipped when any credential is absent, so the same script is safe to run inside the safeoutputs container (which intentionally does not receive GITHUB_SERVER_URL)
actions/setup/sh/start_safe_outputs_mcp.sh (new) — POSIX sh entrypoint script for the gh-aw-node container; calls configure_git_credentials.sh via sh and then execs the safe-outputs MCP server node process
pkg/workflow/git_configuration_steps.go — refactored "Configure Git credentials" step to call bash "${RUNNER_TEMP}/gh-aw/actions/configure_git_credentials.sh" (affects agent job, publish_assets, repo_memory, experiments jobs)
pkg/workflow/compiler_safe_outputs_steps.go — same refactoring in both the single-repo (buildConsolidatedCheckoutSteps) and multi-repo (buildMultiRepoCheckoutSteps) git config step generators; the multi-repo case still appends inline per-subdirectory remote URL lines after the script call
pkg/workflow/mcp_renderer_builtin.go — container entrypoint for the gh-aw-node container is set to sh "${RUNNER_TEMP}/gh-aw/safeoutputs/start_safe_outputs_mcp.sh"; GITHUB_SERVER_URL is intentionally not included in the safeoutputs MCP container env_vars to prevent the container from accessing that secret — configure_git_credentials.sh detects the missing variable and skips remote URL authentication automatically
actions/setup/setup.sh — copies both configure_git_credentials.sh and start_safe_outputs_mcp.sh to ${RUNNER_TEMP}/gh-aw/safeoutputs/ so they are accessible inside the container's mounted volume
actions/setup/js/Dockerfile.safe-outputs-mcp — only git is installed via apk; bash is not required since the entrypoint runs under sh
All lock files regenerated via make recompile
Golden test data and unit tests updated to reflect the new entrypoint

The generated "Configure Git credentials" step now calls the shared script:

- name: Configure Git credentials
  env:
    GITHUB_REPOSITORY: ${{ github.repository }}
    GITHUB_SERVER_URL: ${{ github.server_url }}
    GITHUB_TOKEN: ${{ github.token }}
  run: bash "${RUNNER_TEMP}/gh-aw/actions/configure_git_credentials.sh"

The gh-aw-node container entrypoint runs start_safe_outputs_mcp.sh via sh at startup. That script calls configure_git_credentials.sh (which configures git identity and safe.directory but skips remote authentication since GITHUB_SERVER_URL is not passed to the container) and then launches the MCP server. Main workflow steps (agent job, publish_assets, repo_memory, etc.) receive GITHUB_SERVER_URL and authenticate as before.

✨ PR Review Safe Output Test - Run 27718402567

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · ◷

Changeset\n\n- Type: patch\n- Description: Fix git credential setup to add safe.directory and use a shared POSIX shell entrypoint, resolving dubious ownership errors in safeoutputs and related workflows.

Generated by 📋 Changeset Generator for issue #39771 · ◷

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…e_outputs job Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan

@copilot the git instance running inside the gh-aw-node container needs to be configured. Update Dockerfile for this container.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-06-17T12:46:49Z

@copilot the git instance running inside the gh-aw-node container needs to be configured. Update Dockerfile for this container.

Added git config --global --add safe.directory '*' to actions/setup/js/Dockerfile.safe-outputs-mcp in commit fix: configure git safe.directory in gh-aw-node Dockerfile. This mirrors what's already in the main Dockerfile for the gh-aw container.

…iner entrypoint Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan

@copilot configure safeoutputs MCP env var pre-stripped git server url

Rename SERVER_URL to GIT_SERVER_URL

pelikhan · 2026-06-17T14:29:42Z

@copilot use GITHUB_SERVER_URL instead of GIT_SERVER_URL

…ials step Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-06-17T14:39:39Z

@copilot configure safeoutputs MCP env var pre-stripped git server url

...

Done in commit fix: use GITHUB_REPOSITORY and GIT_SERVER_URL env vars in git credentials step.

Renamed SERVER_URL → GIT_SERVER_URL in the "Configure Git credentials" step env block, the shell script, and the multi-repo inline bash (GIT_SERVER_URL_STRIPPED)
Added GIT_SERVER_URL to the safeoutputs MCP container env_vars list so the container receives it
setup.sh now exports GIT_SERVER_URL="${GITHUB_SERVER_URL#https://}" to GITHUB_ENV so the container gets the pre-stripped URL ready for use in git remote URLs

github-actions · 2026-06-17T20:43:31Z

💫 TO BE CONTINUED... Smoke Claude failed to deliver outputs! Our hero faces unexpected challenges...

github-actions · 2026-06-17T20:43:43Z

🚀 Smoke Pi MISSION COMPLETE! Pi delivered. 🥧

github-actions · 2026-06-17T20:43:47Z

🚀 Smoke Gemini MISSION COMPLETE! Gemini has spoken. ✨

github-actions · 2026-06-17T20:43:48Z

🚀 Smoke Antigravity MISSION COMPLETE! Antigravity has spoken. ✨

github-actions · 2026-06-17T20:43:55Z

✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready.

github-actions · 2026-06-17T20:44:05Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-06-17T20:44:28Z

📰 BREAKING: Smoke Copilot - AOAI (apikey) is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-06-17T20:44:46Z

📰 BREAKING: Smoke Copilot - AOAI (Entra) is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-06-17T20:44:54Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-06-17T20:47:55Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.54.0
jq	✅	1.7
yq	✅	v4.53.3
curl	✅	8.5.0
gh	✅	2.93.0
node	✅	v22.22.3
python3	✅	3.11.15 (PyPy)
go	✅	1.24.13
java	✅	21.0.11
dotnet	✅	10.0.300

Result: 12/12 tools available ✅

Overall Status: PASS

🔧 Tool validation by Agent Container Smoke Test · ◷

github-actions · 2026-06-17T20:50:27Z

Smoke Test Results: GitHub MCP: ✅, Web Fetch: ✅, File Write: ✅, Bash: ✅, Build: ❌. Overall: FAIL.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

✨ Smoke Gemini — Powered by Gemini · ◷

github-actions · 2026-06-17T20:52:48Z

💥 Smoke Test: Claude — Run 27718402567

Core #1-12: ✅ all passed
PR Review #13-18: ✅ all passed
#19 Close PR: ⚠️ skipped (no safe disposable PR)

Overall: PARTIAL (1 skipped) — Claude engine nominal! 🚀

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · ◷

github-actions

💥 Automated smoke test review - all systems nominal!

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude

github-actions · 2026-06-17T20:52:51Z

        env:
-          REPO_NAME: ${{ github.repository }}
-          SERVER_URL: ${{ github.server_url }}
+          GITHUB_REPOSITORY: ${{ github.repository }}


Smoke test: standardizing on GITHUB_REPOSITORY/GITHUB_SERVER_URL env names is a nice consistency improvement. ✅

github-actions · 2026-06-17T20:52:51Z

-          SERVER_URL_STRIPPED="${SERVER_URL#https://}"
-          git remote set-url origin "https://x-access-token:${GITHUB_TOKEN}@${SERVER_URL_STRIPPED}/${REPO_NAME}.git"
-          echo "Git configured with standard GitHub Actions identity"
+        run: bash "${RUNNER_TEMP}/gh-aw/actions/configure_git_credentials.sh"


Smoke test: extracting git config to a shared script reduces duplication across lock files. 👍

github-actions · 2026-06-17T20:53:17Z

Smoke Test: Codex - 27718402592
✅ PR fetch
❌ Serena symbol search
✅ Playwright
✅ Web fetch
✅ File/Bash/Build/Memory
⚪ Issue field skipped
Overall: FAIL

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex · ◷

github-actions · 2026-06-17T20:53:18Z

Comment Memory

Cache wakes at dawn
Builds hum through the quiet wire
Smoke drifts into light

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex · ◷

github-actions · 2026-06-17T20:55:10Z

PR titles only:

fix: add git safe.directory and refactor git config to shell script to resolve dubious ownership error
Suppress ANSI installer colors in CI and explicit no-color environments
Improve copilot billing tip: add org requirement note and billing docs link
✅ 2,3,4,5,6,7,8,9,11,12,13,14,15
❌ 1,10
Overall: FAIL
Author: app/copilot-swe-agent
Assignees: pelikhan, Copilot

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · ◷

github-actions · 2026-06-17T20:55:11Z

Comment Memory

Stone bot hit black keys
Smoke moon watch green build fire dance
Git cave echo pass

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · ◷

github-actions

Smoke pass notes left inline.

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-17T20:58:56Z

Smoke Tests 27718503421:\n• "Suppress ANSI installer colors in CI and explicit no-color environments": ✅\n• "Revert safe-outputs MCP transport to agent-job HTTP sidecar": ✅\n• Serena find_symbol: ❌\n• Other tests (Playwright, curl, file, discussion, build): ✅\nOverall: FAIL\ncc @app/copilot-swe-agent @pelikhan @Copilot

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
safebrowsingohttpgateway.googleapis.com
www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot - AOAI (Entra) · ◷

Initial plan

b1ccaf6

Copilot AI assigned Copilot and pelikhan Jun 17, 2026

Copilot started work on behalf of pelikhan June 17, 2026 12:13 View session

Initial plan for safe.directory fix

652b684

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot mentioned this pull request Jun 17, 2026

[aw] No-Op Runs #38951

Closed

fix: add git safe.directory to prevent dubious ownership error in saf…

e202c46

…e_outputs job Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix missing tools in Instructions Janitor workflow~~ fix: add git safe.directory to resolve dubious ownership error in safe_outputs job Jun 17, 2026

Copilot finished work on behalf of pelikhan June 17, 2026 12:32

Copilot AI requested a review from pelikhan June 17, 2026 12:32

pelikhan reviewed Jun 17, 2026

View reviewed changes

Copilot started work on behalf of pelikhan June 17, 2026 12:38 View session

github-actions Bot mentioned this pull request Jun 17, 2026

[team-status] Daily Status — June 17, 2026 #39786

Closed

fix: configure git safe.directory in gh-aw-node Dockerfile

7ae5846

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~fix: add git safe.directory to resolve dubious ownership error in safe_outputs job~~ fix: add git safe.directory to resolve dubious ownership error in safe_outputs job and gh-aw-node container Jun 17, 2026

Copilot finished work on behalf of pelikhan June 17, 2026 12:47

Copilot AI requested a review from pelikhan June 17, 2026 12:47

pelikhan reviewed Jun 17, 2026

View reviewed changes

Comment thread .github/workflows/ace-editor.lock.yml Outdated

Copilot started work on behalf of pelikhan June 17, 2026 13:31 View session

refactor: extract git config to shell script, run in gh-aw-node conta…

035e4ad

…iner entrypoint Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~fix: add git safe.directory to resolve dubious ownership error in safe_outputs job and gh-aw-node container~~ fix: add git safe.directory and refactor git config to shell script to resolve dubious ownership error Jun 17, 2026

Copilot finished work on behalf of pelikhan June 17, 2026 13:59

Copilot AI requested a review from pelikhan June 17, 2026 13:59

pelikhan reviewed Jun 17, 2026

View reviewed changes

Comment thread .github/workflows/ab-testing-advisor.lock.yml Outdated

Copilot started work on behalf of pelikhan June 17, 2026 14:09 View session

fix: use GITHUB_REPOSITORY and GIT_SERVER_URL env vars in git credent…

3bb5afc

…ials step Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan June 17, 2026 14:40

Copilot finished work on behalf of pelikhan June 17, 2026 20:25

Merge branch 'main' into copilot/instructions-sync

2e736cf

pelikhan added smoke and removed smoke labels Jun 17, 2026

github-actions Bot temporarily deployed to aoai-model June 17, 2026 20:43 Inactive

github-actions Bot temporarily deployed to aoai-model June 17, 2026 20:44 Inactive

github-actions Bot mentioned this pull request Jun 17, 2026

Smoke Test: Claude - 27718402567 #39893

Closed

github-actions Bot added the smoke-claude label Jun 17, 2026

github-actions Bot reviewed Jun 17, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jun 17, 2026

Smoke Test: Copilot - 27718500741 #39895

Closed

github-actions Bot reviewed Jun 17, 2026

View reviewed changes

Merge branch 'main' into copilot/instructions-sync

83bef15

github-actions Bot mentioned this pull request Jun 18, 2026

[aw] No-Op Runs #39849

Open

Conversation

Copilot AI commented Jun 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Changeset\n\n- Type: patch\n- Description: Fix git credential setup to add safe.directory and use a shared POSIX shell entrypoint, resolving dubious ownership errors in safeoutputs and related workflows.

Uh oh!

pelikhan left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 17, 2026

Uh oh!

Uh oh!

pelikhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pelikhan commented Jun 17, 2026

Uh oh!

Copilot AI commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Agent Container Tool Check

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

💥 Smoke Test: Claude — Run 27718402567

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Comment Memory

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Copilot AI commented Jun 17, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading

github-actions Bot commented Jun 17, 2026 •

edited

Loading