Replace non-idiomatic len(string) == 0 checks flagged by lenstringzero

pkg/cli/codemod_checkout_persist_credentials_false.go

@@ -95,7 +95,7 @@ func transformSectionCheckoutPersistCredentials(lines []string, sectionName stri
 	sectionEnd := len(lines) - 1
 	for i := sectionStart + 1; i < len(lines); i++ {
 		trimmed := strings.TrimSpace(lines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		if len(getIndentation(lines[i])) <= len(sectionIndent) {
@@ -135,7 +135,7 @@ func transformAgentJobCheckoutPersistCredentials(lines []string, sectionNames []
 	jobsEnd := len(lines) - 1
 	for i := jobsStart + 1; i < len(lines); i++ {
 		trimmed := strings.TrimSpace(lines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		if len(getIndentation(lines[i])) <= len(jobsIndent) {
@@ -168,7 +168,7 @@ func transformAgentJobCheckoutPersistCredentials(lines []string, sectionNames []
 	agentEnd := len(jobsLines) - 1
 	for i := agentStart + 1; i < len(jobsLines); i++ {
 		trimmed := strings.TrimSpace(jobsLines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		if len(getIndentation(jobsLines[i])) <= len(agentIndent) {
@@ -224,7 +224,7 @@ func transformNestedSectionCheckoutPersistCredentials(lines []string, sectionNam
 	sectionEnd := len(lines) - 1
 	for i := sectionStart + 1; i < len(lines); i++ {
 		trimmed := strings.TrimSpace(lines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		if len(getIndentation(lines[i])) <= len(sectionIndent) {
@@ -252,7 +252,7 @@ func transformNestedSectionCheckoutPersistCredentials(lines []string, sectionNam
 func findDirectChildIndentLen(lines []string, parentStart int, parentIndentLen int) (int, bool) {
 	for i := parentStart + 1; i < len(lines); i++ {
 		trimmed := strings.TrimSpace(lines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		indentLen := len(getIndentation(lines[i]))
@@ -280,7 +280,7 @@ func transformCheckoutWithinSection(sectionLines []string, sectionIndent string)
 			stepEnd := len(sectionLines) - 1
 			for j := i + 1; j < len(sectionLines); j++ {
 				t := strings.TrimSpace(sectionLines[j])
-				if len(t) == 0 {
+				if t == "" {
 					continue
 				}
 				jIndent := getIndentation(sectionLines[j])
@@ -343,7 +343,7 @@ func ensureStepCheckoutPersistCredentials(stepLines []string, stepIndent string)
 			withKeyIndentLen := currentWithKeyIndentLen
 			for j := i + 1; j < len(stepLines); j++ {
 				t := strings.TrimSpace(stepLines[j])
-				if len(t) == 0 {
+				if t == "" {
 					withEnd = j
 					continue
 				}

pkg/cli/codemod_discussion_flag.go

@@ -98,7 +98,7 @@ func getDiscussionFlagRemovalCodemod() Codemod {
 					// Skip any nested content under the discussion field (shouldn't be any, but for completeness)
 					if inDiscussionField {
 						// Empty lines within the field block should be removed
-						if len(trimmedLine) == 0 {
+						if trimmedLine == "" {
 							continue
 						}
 

pkg/cli/codemod_engine_env_secrets.go

@@ -183,7 +183,7 @@ func removeUnsafeEngineEnvKeys(lines []string, unsafeKeys map[string]bool) ([]st
 		}
 
 		if inEnv && removingKey {
-			if len(trimmed) == 0 {
+			if trimmed == "" {
 				continue
 			}
 			if strings.HasPrefix(trimmed, "#") && len(indent) > len(removingKeyIndent) {
@@ -222,7 +222,7 @@ func removeEmptyEngineEnvBlock(lines []string) []string {
 			j := i + 1
 			for ; j < len(lines); j++ {
 				t := strings.TrimSpace(lines[j])
-				if len(t) == 0 {
+				if t == "" {
 					continue
 				}
 				if len(getIndentation(lines[j])) <= len(envIndent) {

pkg/cli/codemod_engine_steps.go

@@ -85,7 +85,7 @@ func getEngineStepsToTopLevelCodemod() Codemod {
 					line := frontmatterLines[j]
 					trimmed := strings.TrimSpace(line)
 
-					if len(trimmed) == 0 {
+					if trimmed == "" {
 						continue
 					}
 
@@ -128,7 +128,7 @@ func getEngineStepsToTopLevelCodemod() Codemod {
 							for j := i + 1; j < len(frontmatterLines); j++ {
 								l := frontmatterLines[j]
 								t := strings.TrimSpace(l)
-								if len(t) == 0 {
+								if t == "" {
 									continue
 								}
 								if len(getIndentation(l)) > len(topStepsIndent) {
@@ -171,7 +171,7 @@ func getEngineStepsToTopLevelCodemod() Codemod {
 							continue
 						}
 						if inEngine {
-							if len(trimmed) == 0 {
+							if trimmed == "" {
 								continue
 							}
 							lineIndentLen := len(getIndentation(line))
@@ -205,7 +205,7 @@ func getEngineStepsToTopLevelCodemod() Codemod {
 							continue
 						}
 						if inEngine {
-							if len(trimmed) == 0 {
+							if trimmed == "" {
 								continue
 							}
 							if len(getIndentation(line)) <= engineIndentLen {

pkg/cli/codemod_github_app.go

@@ -91,7 +91,7 @@ func renameAppToGitHubApp(lines []string) ([]string, bool) {
 		trimmed := strings.TrimSpace(line)
 
 		// Skip empty lines without resetting state
-		if len(trimmed) == 0 {
+		if trimmed == "" {
 			result = append(result, line)
 			continue
 		}

pkg/cli/codemod_github_app_client_id.go

@@ -65,7 +65,7 @@ func renameGitHubAppIDToClientID(lines []string) ([]string, bool) {
 	for i, line := range lines {
 		trimmed := strings.TrimSpace(line)
 
-		if len(trimmed) == 0 {
+		if trimmed == "" {
 			result = append(result, line)
 			continue
 		}

pkg/cli/codemod_github_repos.go

@@ -69,7 +69,7 @@ func renameGitHubReposToAllowedRepos(lines []string) ([]string, bool) {
 		trimmed := strings.TrimSpace(line)
 
 		// Skip empty lines without resetting state
-		if len(trimmed) == 0 {
+		if trimmed == "" {
 			result = append(result, line)
 			continue
 		}

pkg/cli/codemod_mcp_network.go

@@ -204,7 +204,7 @@ func removeFieldFromMCPServer(lines []string, serverName string, fieldName strin
 		// Skip nested properties under the field
 		if inFieldBlock {
 			// Empty lines within the field block should be removed
-			if len(trimmedLine) == 0 {
+			if trimmedLine == "" {
 				continue
 			}
 
@@ -252,7 +252,7 @@ func addTopLevelNetwork(lines []string, domains []string) []string {
 				for j := i + 1; j < len(lines); j++ {
 					nextLine := lines[j]
 					nextTrimmed := strings.TrimSpace(nextLine)
-					if len(nextTrimmed) == 0 {
+					if nextTrimmed == "" {
 						continue
 					}
 					if hasExitedBlock(nextLine, onIndent) {
@@ -328,7 +328,7 @@ func updateNetworkAllowed(lines []string, domains []string) []string {
 			currentIndent := getIndentation(line)
 
 			// Empty lines - skip
-			if len(trimmedLine) == 0 {
+			if trimmedLine == "" {
 				continue
 			}
 

pkg/cli/codemod_mount_as_clis.go

@@ -90,7 +90,7 @@ func renameMountAsCLIsToCLIProxy(lines []string) ([]string, bool) {
 	for i, line := range lines {
 		trimmed := strings.TrimSpace(line)
 
-		if len(trimmed) == 0 {
+		if trimmed == "" {
 			result = append(result, line)
 			continue
 		}

pkg/cli/codemod_playwright_domains.go

@@ -160,7 +160,7 @@ func removeFieldFromPlaywright(lines []string, fieldName string) ([]string, bool
 
 		// Skip nested properties under the removed field
 		if inFieldBlock {
-			if len(trimmed) == 0 {
+			if trimmed == "" {
 				continue
 			}
 			currentIndent := getIndentation(line)

pkg/cli/codemod_steps_run_secrets_env.go

@@ -86,7 +86,7 @@ func transformSectionStepsRunSecrets(lines []string, sectionName string) ([]stri
 	sectionEnd := len(lines) - 1
 	for i := sectionStart + 1; i < len(lines); i++ {
 		trimmed := strings.TrimSpace(lines[i])
-		if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+		if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 			continue
 		}
 		if len(getIndentation(lines[i])) <= len(sectionIndent) {
@@ -125,7 +125,7 @@ func transformStepsWithinSection(sectionLines []string, sectionIndent string) ([
 			stepEnd := len(sectionLines) - 1
 			for j := i + 1; j < len(sectionLines); j++ {
 				t := strings.TrimSpace(sectionLines[j])
-				if len(t) == 0 {
+				if t == "" {
 					continue
 				}
 				jIndent := getIndentation(sectionLines[j])
@@ -199,7 +199,7 @@ func rewriteStepRunSecretsToEnv(stepLines []string, stepIndent string) ([]string
 			envEnd = i
 			for j := i + 1; j < len(stepLines); j++ {
 				t := strings.TrimSpace(stepLines[j])
-				if len(t) == 0 {
+				if t == "" {
 					envEnd = j
 					continue
 				}
@@ -225,7 +225,7 @@ func rewriteStepRunSecretsToEnv(stepLines []string, stepIndent string) ([]string
 		if runValue == "|" || runValue == "|-" || runValue == ">" || runValue == ">-" {
 			for j := i + 1; j < len(stepLines); j++ {
 				t := strings.TrimSpace(stepLines[j])
-				if len(t) == 0 {
+				if t == "" {
 					continue
 				}
 				if effectiveStepLineIndentLen(t, getIndentation(stepLines[j]), stepIndent) <= runKeyIndentLen {

pkg/cli/codemod_user_rate_limit.go

@@ -46,7 +46,7 @@ func renameRateLimitToUserRateLimit(lines []string) ([]string, bool) {
 	for i, line := range lines {
 		trimmed := strings.TrimSpace(line)
 
-		if len(trimmed) == 0 {
+		if trimmed == "" {
 			result = append(result, line)
 			continue
 		}

pkg/cli/mcp_tools_readonly.go

@@ -234,7 +234,7 @@ Returns JSON array with validation results for each workflow:
 		if err != nil {
 			mcpLog.Printf("Compile command exited with error: %v (output length: %d)", err, len(outputStr))
 			// If we have no output, this is a real execution failure
-			if len(outputStr) == 0 {
+			if outputStr == "" {
 				// Try to get stderr for error details
 				var stderr string
 				var exitErr *exec.ExitError

pkg/cli/project_command.go

@@ -255,7 +255,7 @@ func validateOwner(ctx context.Context, ownerType, owner string, verbose bool) e
 
 // capitalizeFirst capitalizes the first letter of a string
 func capitalizeFirst(s string) string {
-	if len(s) == 0 {
+	if s == "" {
 		return s
 	}
 	return strings.ToUpper(s[:1]) + s[1:]

pkg/cli/remove_command.go

@@ -419,7 +419,7 @@ func findIncludesInContent(content string) ([]string, error) {
 // Section references (e.g. file.md#Section) are stripped from the returned path.
 func parseIncludePath(line string) string {
 	trimmed := strings.TrimSpace(line)
-	if len(trimmed) == 0 {
+	if trimmed == "" {
 		return ""
 	}
 
@@ -471,7 +471,7 @@ func parseIncludePath(line string) string {
 		rest = rest[1:]
 	}
 	// Require at least one whitespace character after the directive keyword
-	if len(rest) == 0 || (rest[0] != ' ' && rest[0] != '\t') {
+	if rest == "" || (rest[0] != ' ' && rest[0] != '\t') {
 		return ""
 	}
 	path := strings.TrimSpace(rest)

pkg/cli/run_push.go

@@ -406,7 +406,7 @@ func pushWorkflowFiles(workflowName string, files []string, refOverride string,
 	runPushLog.Printf("Git status output: %s", string(statusOutput))
 
 	// Check if there are no staged changes (nothing to commit)
-	if len(strings.TrimSpace(string(statusOutput))) == 0 {
+	if strings.TrimSpace(string(statusOutput)) == "" {
 		runPushLog.Printf("No staged changes detected")
 		if verbose {
 			fmt.Fprintln(os.Stderr, console.FormatInfoMessage("No changes to commit"))

pkg/cli/run_workflow_execution.go

@@ -78,7 +78,7 @@ func RunWorkflowOnGitHub(ctx context.Context, workflowIdOrName string, opts RunO
 		}
 		// Check that key (before '=') is not empty
 		parts := strings.SplitN(input, "=", 2)
-		if len(parts[0]) == 0 {
+		if parts[0] == "" {
 			return fmt.Errorf("invalid input format '%s': key cannot be empty", input)
 		}
 	}

pkg/cli/trial_helpers.go

@@ -349,7 +349,7 @@ func copyTrialResultsToHostRepo(tempDir, dateTimeID string, workflowNames []stri
 	}
 
 	// If no changes, skip commit and push
-	if len(strings.TrimSpace(string(statusOutput))) == 0 {
+	if strings.TrimSpace(string(statusOutput)) == "" {
 		trialLog.Print("No new trial results to commit, skipping push")
 		if verbose {
 			fmt.Fprintln(os.Stderr, console.FormatInfoMessage("No new trial results to commit"))

pkg/cli/trial_repository.go

@@ -494,7 +494,7 @@ func commitAndPushWorkflow(tempDir, workflowName string, verbose bool) error {
 	}
 
 	// If no changes, skip commit and push
-	if len(strings.TrimSpace(string(statusOutput))) == 0 {
+	if strings.TrimSpace(string(statusOutput)) == "" {
 		if verbose {
 			fmt.Fprintln(os.Stderr, console.FormatInfoMessage("No changes detected, skipping commit"))
 		}

pkg/cli/validators.go

@@ -35,7 +35,7 @@ func ValidateWorkflowName(s string) error {
 func ValidateWorkflowIntent(s string) error {
 	validatorsLog.Printf("Validating workflow intent: length=%d", len(s))
 	trimmed := strings.TrimSpace(s)
-	if len(trimmed) == 0 {
+	if trimmed == "" {
 		validatorsLog.Print("Workflow intent validation failed: empty content")
 		return errors.New("workflow instructions cannot be empty")
 	}

pkg/cli/yaml_frontmatter_utils.go

@@ -52,11 +52,11 @@ func getIndentation(line string) string {
 // isTopLevelKey checks if a line is a top-level YAML key (no indentation, contains colon, not a comment)
 func isTopLevelKey(line string) bool {
 	trimmed := strings.TrimSpace(line)
-	if len(trimmed) == 0 || strings.HasPrefix(trimmed, "#") {
+	if trimmed == "" || strings.HasPrefix(trimmed, "#") {
 		return false
 	}
 	indent := getIndentation(line)
-	return len(indent) == 0 && strings.Contains(line, ":")
+	return indent == "" && strings.Contains(line, ":")
 }
 
 // isNestedUnder checks if currentLine is nested under (has more indentation than) parentIndent
@@ -68,7 +68,7 @@ func isNestedUnder(currentLine, parentIndent string) bool {
 // hasExitedBlock checks if we've left a YAML block (found a line with same or less indentation that's a key)
 func hasExitedBlock(line, blockIndent string) bool {
 	trimmed := strings.TrimSpace(line)
-	if len(trimmed) == 0 {
+	if trimmed == "" {
 		return false
 	}
 
@@ -206,7 +206,7 @@ func removeFieldFromBlock(lines []string, fieldName string, parentBlock string)
 		// Skip nested properties under the field (lines with greater indentation)
 		if inFieldBlock {
 			// Empty lines within the field block should be removed
-			if len(trimmedLine) == 0 {
+			if trimmedLine == "" {
 				continue
 			}
 

pkg/console/input.go

@@ -28,7 +28,7 @@ func PromptSecretInput(title, description string) (string, error) {
 				Description(description).
 				EchoMode(huh.EchoModePassword). // Masks input for security
 				Validate(func(s string) error {
-					if len(s) == 0 {
+					if s == "" {
 						return errors.New("value cannot be empty")
 					}
 					return nil

pkg/gitutil/gitutil.go

@@ -49,7 +49,7 @@ func IsAuthError(errMsg string) bool {
 // IsHexString checks if a string contains only hexadecimal characters.
 // This is used to validate Git commit SHAs and other hexadecimal identifiers.
 func IsHexString(s string) bool {
-	if len(s) == 0 {
+	if s == "" {
 		return false
 	}
 	for _, c := range s {

pkg/parser/github_urls.go

@@ -360,7 +360,7 @@ const (
 func isValidGitHubNameWithMaxLength(s string, maxLength int) bool {
 	// GitHub identifiers can contain alphanumeric characters, hyphens, and underscores.
 	// They cannot start or end with a hyphen.
-	if len(s) == 0 || len(s) > maxLength {
+	if s == "" || len(s) > maxLength {
 		return false
 	}
 	if s[0] == '-' || s[len(s)-1] == '-' {

pkg/parser/import_directive.go

@@ -29,7 +29,7 @@ func ParseImportDirective(line string) *ImportDirectiveMatch {
 	trimmedLine := strings.TrimSpace(line)
 
 	// Fast-path: import directives must start with '@' or '{'; skip the regex for all other lines.
-	if len(trimmedLine) == 0 || (trimmedLine[0] != '@' && trimmedLine[0] != '{') {
+	if trimmedLine == "" || (trimmedLine[0] != '@' && trimmedLine[0] != '{') {
 		return nil
 	}