Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[docs] Self-healing documentation fixes from issue analysis - 2026-06-09 #37980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Self-healing documentation fixes from issue analysis - 2026-06-09 #37980
Changes from all commits
21e169dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] Missing default value — the description does not state what happens when
disable-model-invocationis omitted.Sibling fields like
check-for-updatesexplicitly say "Whentrue(default)" or "The default isfalse". Without a stated default, users cannot know whether model invocation is on or off when the field is absent.💡 Suggested addition
Append to the first paragraph:
This matches the pattern established by
check-for-updatesjust above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] Description drifts from
frontmatter-full.md— the two pages describe the same field differently.frontmatter-full.mdsays the field means "the agent will not make additional model calls", while this curated section says "downstream tooling treats the agent as documentation-only." These framings are semantically distinct (runtime behavior vs. metadata marker) and could leave readers unsure which is accurate.💡 Suggested alignment
Pick one canonical framing and use it consistently. The
frontmatter-full.mdversion is auto-generated from the schema description; aligning the curated prose to match (or updating the schema description to match the curated prose) would make both pages consistent:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing default: the description doesn't say what the default is when the field is omitted, leaving users unsure whether model invocation is enabled by default.
💡 Suggested fix
The adjacent
check-for-updatessection sets the pattern: "Whentrue(default)...". Apply the same convention here. Since omitting the field means model invocation is enabled, add a sentence like:Without this, users have no way to know the field's default from the reference page alone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/grill-with-docs] Back-reference to
infermay conflict with ADR-33808 — consider removing it from the field description.ADR-33808 §"Schema and Parser" rule 4 states: "The
disable-model-invocationfield description MUST NOT contain a back-reference toinfer." The sentence "Thegh aw fix --writecodemodinfer-to-disable-model-invocationmigrates the deprecatedinfer:field to this one, inverting the boolean" directly names the deprecated field. The ADR’s rationale is to avoid burdening new readers with a concept they should never need to know.💡 Suggested revision
Remove the codemod sentence from this paragraph entirely. Users who need to migrate from the deprecated
inferfield can rungh aw fix --writeand the codemod handles the conversion automatically — they don’t need the curated reference page to explain it.If migration guidance is still desired, a dedicated "Migration from
infer" section elsewhere (e.g., a migration guide or the codemod’s own docs page) would keep this reference page clean.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADR-33808 normative violation: this sentence back-references the deprecated
infer:field, which the project ADR explicitly forbids in this description.💡 Details and fix
ADR-33808 Part 2 "Schema and Parser" item 4 states:
The sentence to remove:
Drop it entirely. Migration guidance belongs in release notes, not in the field reference — and the ADR prohibits it here. The preceding sentence already gives users sufficient context for when to use this field.
Uh oh!
There was an error while loading. Please reload this page.